From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 640E847CE for ; Fri, 6 Oct 2017 02:29:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0231720E1D; Thu, 5 Oct 2017 20:29:06 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 05 Oct 2017 20:29:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=MLr2uCxxI+D8nVW lnSZ04/EnTYS1apEsNyG9U30aws4=; b=ULwhIxeaKczx+iBU0gyluftpRUeDKa3 +9dAhG+QRNTvNixGaAd4XSTJsZ/wI8XVj9sS/bn5Rx3cXDr+SVuRxzaGXuctG7uJ e8j/k5VSnv8Gfv5sz42wc9I3MFsXWvMnSf/sINO4Um3Fbbw2PWvZQUS54i3s+Srk SbSkT9A4RJCM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=MLr2uCxxI+D8nVWlnSZ04/EnTYS1apEsNyG9U30aws4=; b=EP7mth/W pP2BhlQ0Nzo56N+WnjmMr3D6B+I0sizeOYgwzXZ8mFYuqszox2uTB29v3zxtiUzh gTR41cPl7/1OLy8UkkivVz7Lw6mdyxGYGUla9JFh5rAKatbkzhEddSjQI2EjTRnt BouphrbUNyN8XLVYJHnLdWmwtuY4MtlbgzniFNqNbjhJdkx8cYgUMmfWIImutQjB wNhTWYbYJ8cZC1Azf4GgI2et0mXI9f3GqdCN76XykJXXh5f77JM6PYJmRh8219qD sCWWWE8v0onsV8UUB3ArfivJFwVWzlAkvW0sX1Y+NEHcFJU+ZWCzn3det4FeaZdX 1JJiY6Dy/Q5AWw== X-ME-Sender: X-Sasl-enc: kaZNRmE15WoE4xNKHtS+iYiKV+6ejE4lxwaYjMXSRAQo 1507249745 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AB33F2418B; Thu, 5 Oct 2017 20:29:05 -0400 (EDT) From: Thomas Monjalon To: Santosh Shukla Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com Date: Fri, 06 Oct 2017 02:29:04 +0200 Message-ID: <1712938.NqKmOO8lQc@xps> In-Reply-To: <20171001091440.10232-2-santosh.shukla@caviumnetworks.com> References: <20170911151837.25092-1-santosh.shukla@caviumnetworks.com> <20171001091440.10232-1-santosh.shukla@caviumnetworks.com> <20171001091440.10232-2-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/2] eal: allow user to override default pool handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 00:29:06 -0000 01/10/2017 11:14, Santosh Shukla: > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -98,6 +98,7 @@ eal_long_options[] = { > {OPT_VFIO_INTR, 1, NULL, OPT_VFIO_INTR_NUM }, > {OPT_VMWARE_TSC_MAP, 0, NULL, OPT_VMWARE_TSC_MAP_NUM }, > {OPT_XEN_DOM0, 0, NULL, OPT_XEN_DOM0_NUM }, > + {OPT_MBUF_POOL_OPS_NAME, 1, NULL, OPT_MBUF_POOL_OPS_NAME_NUM}, > {0, 0, NULL, 0 } > }; I think the options were sorted alphabetically. [...] > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -82,7 +82,7 @@ struct internal_config { > volatile enum rte_intr_mode vfio_intr_mode; > const char *hugefile_prefix; /**< the base filename of hugetlbfs files */ > const char *hugepage_dir; /**< specific hugetlbfs directory to use */ > - > + const char *mbuf_pool_ops_name; /**< mbuf pool ops name */ Why this config is not stored in mbuf.c?