From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E78FFAABE
 for <dev@dpdk.org>; Tue, 17 Apr 2018 00:56:39 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 9092821E93;
 Mon, 16 Apr 2018 18:56:39 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 16 Apr 2018 18:56:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=TKXB57Jnsp65i7Aa1Bn302mhAn
 ommeaiF64ZR91awkI=; b=JaIgUi+aXMGszUFa2XJjryvhCCqSqyp6EO4dh1mSod
 gK0eNqMqLtx+6/+kgDrTQoY8FHoc36zjbylgBqBkz3QLpafKWX3bW+iC5scQ8Vyu
 zfGHYIThouFBYsPdTY5pAqtmmkNpMQi5KtcWarEAwTo3C7DWPEdwXwYvjvhDXxKM
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TKXB57
 Jnsp65i7Aa1Bn302mhAnommeaiF64ZR91awkI=; b=m6iSPksZunjKZ/hUWrzY1z
 eoP/0t6m2bDLsPJsoAyFKlWu4+cHGPpsMwG5RyYxj/smYxlJoqskTMursMwHpLgd
 zlwWz5eEpHapnsIXCENw7vBNrey2YnlgfUDix3+0QY8JCWwLZE4NcBpOrKlOolyY
 +b8HRCT1m6RUuDWQ5IqMdOJehLOShU1udfLSusD44utI2yQEsJsLpViiYNt3NtKV
 FNmyq7kYmSXixD9Gw+NI36zwAvzbzaoICuMOfijmvzgqhXJuRHW/6HvGgEcTPoWy
 EmrfZnldZBfZTrISbRzoqyGtG8tDNDajxlZxb4A0c50Ny58pWW6/AURptSJGZgRQ
 ==
X-ME-Sender: <xms:JyrVWl-6P_SK2JXGfC4kav3l7mqpOXTUZ4DQCRAvNfBPOxqaw6agvw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 60CAFE49AD;
 Mon, 16 Apr 2018 18:56:38 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <notifications@github.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, arybchenko@solarflare.com,
 ferruh.yigit@intel.com
Date: Tue, 17 Apr 2018 00:56:36 +0200
Message-ID: <1713016.yCs8GSPTMd@xps>
In-Reply-To: <20180409121035.148813-1-xuemingl@mellanox.com>
References: <20180318073720.84176-1-xuemingl@mellanox.com>
 <20180409121035.148813-1-xuemingl@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 1/2] ethdev: add supported hash function
	check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 22:56:40 -0000

09/04/2018 14:10, Xueming Li:
> Add supported RSS hash function check in device configuration to
> have better error verbosity for application developers.

In other words, you check whether the requested RSS type is supported.

I don't see any reason to not accept it.
Any other comment?