Re: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove

[Thomas Monjalon <thomas@monjalon.net>]

05/11/2018 13:19, Kevin Traynor:
> On 11/01/2018 02:46 PM, Thomas Monjalon wrote:
> > The functions rte_dev_probe() and rte_dev_remove() are new
> > in DPDK 18.11 so they got the experimental tag by policy.
> > However they are too much basic functions for being skipped
> > by strict applications which do not use experimental functions.
> > 
> > The alternative is to use rte_eal_hotplug_add() and
> > rte_eal_hotplug_remove(), but their API requires the application
> > to parse the devargs string in order to provide bus name,
> > device name and driver arguments.
> > 
> > The new function rte_dev_probe() is really simpler to use and
> > more flexible by accepting any devargs string.
> > Let's encourage applications to use it.
> > 
> > The old functions rte_eal_hotplug_* may be deprecated later.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> one minor comment below, but it's no big deal..
> 
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
> Tested-by: Kevin Traynor <ktraynor@redhat.com>
[...]
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -262,6 +262,8 @@ DPDK_18.11 {
> >  	rte_eal_get_runtime_dir;
> >  	rte_eal_hotplug_add;
> >  	rte_eal_hotplug_remove;
> > +	rte_dev_probe;
> > +	rte_dev_remove;
> 
> maybe you want to keep these in alphabetical order

Oh yes, I must revise the alphabetical order!
Thanks