From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A3F9D49E0 for ; Mon, 5 Nov 2018 14:13:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 710E420B71; Mon, 5 Nov 2018 08:13:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 05 Nov 2018 08:13:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cKUGxscl6Ofaj1mogmVTA2FrzR99BIiFMIe0Tj0V3nI=; b=HLJWJpLK/nmA ArJPYda2ty03S0W4pBMqWu6pfUnie1SjZt5nWga+fr/zc6kReoCDmiE9Y9fGw8Mi DVOfgSx5Kqjzg+slkj1owHW5UvoBzX+2wiEZqxeXsAl3sWK6TLc797Qgt6jvgTqG ilHQ0Yl/YLJBxzEJ/Ee2ed7c2MdjoQo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cKUGxscl6Ofaj1mogmVTA2FrzR99BIiFMIe0Tj0V3 nI=; b=J/x7Wcjm04yvr4afHGGXfqv5hfF0+XQ8JxF157srgGB4I8U4wRKOLGJ3a opWDYffsZ4XsMgNSX4YC/FuVur2Pwlqhu4i+uESUYFb2FAbat/qOEGwi5oafF1FF DnR8R5NdMiaO0ToyntsZl4xzkyW1fh0anRfscvXiZLwij2ZPZ4vUP+BjVUHhNoW8 xhhH7dyXXvLwAChQhqEa+7Eo0L58EV17nqA5ZsO5+AoUK8B8YYSp0jQNyYMwzPhS Cn1vkSMTzlp2oFrTQpifD7BrE1QFggpB9/bZeDvikqawcYhbMDmm0+oVhuQ1wwBq /nBa6INASSvPNnIi1QRg39oca2RKQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 71805102E0; Mon, 5 Nov 2018 08:13:53 -0500 (EST) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ian.stokes@intel.com Date: Mon, 05 Nov 2018 14:13:52 +0100 Message-ID: <1715062.3G7La7yUx6@xps> In-Reply-To: <13462be0-7835-144a-143f-1e0d30343503@redhat.com> References: <20181101144633.13429-1-thomas@monjalon.net> <20181101144633.13429-2-thomas@monjalon.net> <13462be0-7835-144a-143f-1e0d30343503@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 13:13:58 -0000 05/11/2018 13:19, Kevin Traynor: > On 11/01/2018 02:46 PM, Thomas Monjalon wrote: > > The functions rte_dev_probe() and rte_dev_remove() are new > > in DPDK 18.11 so they got the experimental tag by policy. > > However they are too much basic functions for being skipped > > by strict applications which do not use experimental functions. > > > > The alternative is to use rte_eal_hotplug_add() and > > rte_eal_hotplug_remove(), but their API requires the application > > to parse the devargs string in order to provide bus name, > > device name and driver arguments. > > > > The new function rte_dev_probe() is really simpler to use and > > more flexible by accepting any devargs string. > > Let's encourage applications to use it. > > > > The old functions rte_eal_hotplug_* may be deprecated later. > > > > Signed-off-by: Thomas Monjalon > > one minor comment below, but it's no big deal.. > > Acked-by: Kevin Traynor > Tested-by: Kevin Traynor [...] > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -262,6 +262,8 @@ DPDK_18.11 { > > rte_eal_get_runtime_dir; > > rte_eal_hotplug_add; > > rte_eal_hotplug_remove; > > + rte_dev_probe; > > + rte_dev_remove; > > maybe you want to keep these in alphabetical order Oh yes, I must revise the alphabetical order! Thanks