From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id 750422BB0 for ; Fri, 31 Mar 2017 11:56:45 +0200 (CEST) Received: by mail-lf0-f45.google.com with SMTP id x137so41120072lff.3 for ; Fri, 31 Mar 2017 02:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=lm1Nzc3iJVl+HyjcAXubLceEbchSG4yoh7lhe+WCbgI=; b=dKmtX9qzafLmbeGWgav523pKnTSLrPTPhnJEWyeoPQhJhXG1NBSd9SigWVuV70QoKS KJsw9xv6KPErE9oDSlHKyK3FXF8Sg/X4zn3+NWAruIQUCC/QCWvXxrOhnZnl0LHcSsLb hugI7+o0+7/u9f+DTlRkzEZrXrm+W09If4UFmyf27dpAAixVd/ebfd4dp7C7PgFxhOU4 CDZuNwbaYqH0oNu6VTEJSm2CxGJFuuG4wLoghzNKey4/UyvYe2aY+RV67ZM2U2dqJCbS +kgr0YjHjbNedSOSMWTGbAltnwDUZx69tUosxCeExZawTnyRdTjIBdcmJzq06x2l8qBO 8blg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=lm1Nzc3iJVl+HyjcAXubLceEbchSG4yoh7lhe+WCbgI=; b=M6QybVLQ9QphNaw+s5nzC+4cHd4FKo1MeOGYcBUJ5PVSjAtduJV/9jaa2r3ugOMKhV CassQy1THub+h4Ek/rwcA33OCMcyCwA+EZckC1LIhKFKnC887bPXXLhQKfIcKZ+5pYqs PdozPiKJjxepbJgLy88evyB7cHHDlg7Y27QRLUqtsM0tSH1s9pvC5E25bKlOZGeGvBIW r0rJO75ElUC3Syqx3h5Cd8D+mvx4kDjL57GZlNl9ihKgeykQRpGIeZ5mwgUG5bHypfmD hmtz8y1TRaf7CskiKalVp4Ce5mGGSLpYUGAjHASYNll1gn+woKCZOcoxqFW5Uhmx87L9 IL9A== X-Gm-Message-State: AFeK/H1KFhp3cu8C+89dt0sYGdZLjLBL0vD+Yo2zwYCpiiuTVutJn+rmy3Yr2snrINIvz32+ X-Received: by 10.28.194.7 with SMTP id s7mr2017691wmf.34.1490954204922; Fri, 31 Mar 2017 02:56:44 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id o15sm6051433wra.61.2017.03.31.02.56.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Mar 2017 02:56:44 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Date: Fri, 31 Mar 2017 11:56:43 +0200 Message-ID: <1715505.Fdacs5PODr@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170331091509.GC7668@bricha3-MOBL3.ger.corp.intel.com> References: <20170329140419.27149-1-bruce.richardson@intel.com> <1775524.8P82GFJXp7@xps13> <20170331091509.GC7668@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 09:56:45 -0000 2017-03-31 10:15, Bruce Richardson: > On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote: > > 2017-03-30 16:30, Bruce Richardson: > > > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote: > > > > 2017-03-29 17:38, Bruce Richardson: > > > > > Since performance-thread example app is now built as part of make examples > > > > > we don't need a special case line for it in testbuild.sh script > > > > [...] > > > > > --- a/devtools/test-build.sh > > > > > +++ b/devtools/test-build.sh > > > > > @@ -237,9 +237,6 @@ for conf in $configs ; do > > > > > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > > > > > O=$(readlink -m $dir/examples) > > > > > ! echo $target | grep -q '^x86_64' || \ > > > > > - make -j$J -sC examples/performance-thread \ > > > > > - EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ > > > > > - O=$(readlink -m $dir/examples/performance-thread) > > > > > > > > You are missing the x86_64 check. > > > > > > That's in the makefile in the first patch > > > > Sorry, I mean you should remove the above check: > > ! echo $target | grep -q '^x86_64' || \ > > > Oops, yes, you are right. Do you need a V3 of this set, or can you just > fix it up as you like it on apply? Please send a new version for this fix and the short break in next patch.