From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 1F2895921 for ; Wed, 22 Jul 2015 12:47:54 +0200 (CEST) Received: by wibxm9 with SMTP id xm9so95805952wib.1 for ; Wed, 22 Jul 2015 03:47:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=D96Rgl5zB8TmbQOESG6Sil9k7GfZGaJTh+CnCcTgydE=; b=UrskuApjxxU+D7lSsROdynpPTWgjKqQXpC90I32pl+wJsKiyzABMGDl/wBd3j1ki+n hCqfWDWj42wvlVMyuufFS5uv13BTBZrbeSo9tZi+ornI2mcPjEg3cVpvL+00NX18Moh+ Xa9cahxMP8SiG+AKN6zZd8/FZvb3ZuoGVG9B4YR8Qi7fBz4G17xYD1xha7rI7RARYLfl P9xLHoWF0+tQIgXR8i32DgcpvBFkW6YqMKsGo43vPttJAHk0R+EKa86sGRUMueDpNJrU kKMJkofK9WxHV7DDOdTsFbDkdzUf31sf0dnsVuhvlIr7hg14QATK7ci8oNT9+MqQn+L1 WWVQ== X-Gm-Message-State: ALoCoQm4dlwvKr9RhXmQkaJ3d3UUNt+Obkxjyk3reNE9fRnJ8bvvjsFc20be4NrzgQSvAG+Kh/n+ X-Received: by 10.180.91.40 with SMTP id cb8mr28714910wib.54.1437562074023; Wed, 22 Jul 2015 03:47:54 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id dz4sm21385977wib.17.2015.07.22.03.47.51 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jul 2015 03:47:52 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Wed, 22 Jul 2015 12:46:40 +0200 Message-ID: <1715547.l9Ey1F3lgG@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D0172404A@shsmsx102.ccr.corp.intel.com> References: <1437093202-30265-1-git-send-email-stephen@networkplumber.org> <4341B239C0EFF9468EE453F9E9F4604D0172404A@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fm10K: fix interrupt fault handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 10:47:54 -0000 > > The fm10k driver was reading the interrupt cause register but then > > using the interrupt mask register defines to look at the bits. > > The result is that if a fault happens, the driver would never clear > > the fault and would get into an infinite cycle of interrupts. > > > > Note: I don't work for Intel or have the hardware manuals (probably > > requires NDA anyway), but this looks logical and matches how the > > known working Linux driver handles these bits. > > > > Signed-off-by: Stephen Hemminger > > Good catch! Thanks! > > Acked-by: Jing Chen Applied, thanks