From: Thomas Monjalon <thomas@monjalon.net>
To: Tonghao Zhang <nic@opencloud.tech>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.
Date: Wed, 10 May 2017 14:45:00 +0200 [thread overview]
Message-ID: <1716317.nSDOrcW80P@xps> (raw)
In-Reply-To: <1494315002-41982-1-git-send-email-nic@opencloud.tech>
09/05/2017 09:30, Tonghao Zhang:
> The NUMA node information for PCI devices provided through
> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
> on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
Sorry I don't understand the range of affected platforms.
Is it only on Opteron? Opteron with RHEL6? Is it fixed in recent kernels?
Which hypervisors? with which kernel?
> It is good to see more checking for valid values.
If values are wrong, what can we do?
Here you check that value is not too high.
What about other kind of wrong values?
> Signed-off-by: Tonghao Zhang <nic@opencloud.tech>
[...]
> - /* get numa node */
> + /* get numa node, default to 0 if not present */
> snprintf(filename, sizeof(filename), "%s/numa_node",
> dirname);
> - if (access(filename, R_OK) != 0) {
> - /* if no NUMA support, set default to 0 */
> - dev->device.numa_node = 0;
Why removing the access() check?
> - } else {
> - if (eal_parse_sysfs_value(filename, &tmp) < 0) {
> - free(dev);
> - return -1;
> - }
> +
> + if (eal_parse_sysfs_value(filename, &tmp) == 0 &&
> + tmp < RTE_MAX_NUMA_NODES)
> dev->device.numa_node = tmp;
> - }
> + else
> + dev->device.numa_node = 0;
It would deserve at least a warning log.
next prev parent reply other threads:[~2017-05-10 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 7:30 Tonghao Zhang
2017-05-10 12:45 ` Thomas Monjalon [this message]
2017-05-10 14:20 ` nickcooper-zhangtonghao
2017-06-01 1:22 ` nickcooper-zhangtonghao
-- strict thread matches above, loose matches on Subject: below --
2017-05-09 6:55 Tonghao Zhang
2017-05-09 6:45 Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1716317.nSDOrcW80P@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=nic@opencloud.tech \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).