From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id DDD544B79 for ; Fri, 7 Oct 2016 14:14:06 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id k125so28859848wma.1 for ; Fri, 07 Oct 2016 05:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=0V5cOJJ3u5TN3F8Dm4GNGyDNEvOsr1qxad6nTiWpYcI=; b=sj1VUBPo9XDtfKc6MKdeh9H0XYuiPdXRHxSnQNllzhLjKBk58bdyXLnJxLnrHcmTEv LIDMNxGUpRvaHTtaPIJxoQ5VGFU0/GpQCjIkvr1CXsTS21Dsz+c2uZRoIzWVBfZ0PnHK vfQONS4nKnonwN4i3odeJY8nysZjVkZSLzS695JhLzP4QF96SqJ9OUbfUJHOFMoqOhd4 tQtsfx5yepTu+SfmBx+x77xkBbx+BPlV66UD1FtyNi4LEfwJbG1jjwP+uPUivLDgRbwQ J0dsxo1NKkNZ9cSQeDjCBIZb5FWMkeakx1vvW4k1lIREeRNmWbD7OPKDWuSokcWUOVOC PgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=0V5cOJJ3u5TN3F8Dm4GNGyDNEvOsr1qxad6nTiWpYcI=; b=VSzXxvq7J7i6AHp/U2A4DtQBq+GjgD3ORYdGMhW+OrGyUoJN5vMoIzArPxGM3uS9c4 IHUDDVo0Stypblb9JJU8WdBpWfUxmDT4Jn7QL1oSe9lYVoC23+G6nbhEer32r26UIsL1 QBg4CNeBezYZam3FG9R7B2dg/PvFzOiGVKx+hkpoGzYZGxHHHj67nAYOleuiNbR3uDlX DzHPT3HpJS4khusZGSLyu5CjlF3rMdFiDEsNytRbfhqvgQjqeJhqVAegyt7uyKFhHtl3 EKLAMj3G4y6FGxeVHtAI83iI4qysFmw/o9kg8tGBKcaOi+A4ks7bq/VHZ53Zq44G08g6 BiTg== X-Gm-Message-State: AA6/9Rkyhxq96HF0Q8c5EO+a8UKEG3RSNULvQ2FSqCodwFhbGJ2MFvtb8rM+QGEv8VOW1mm7 X-Received: by 10.28.139.19 with SMTP id n19mr17633651wmd.71.1475842444158; Fri, 07 Oct 2016 05:14:04 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id lj2sm19355983wjc.38.2016.10.07.05.14.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 05:14:03 -0700 (PDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, rahul.r.shah@intel.com, wenzhuo.lu@intel.com, az5157@att.com, jerin.jacob@caviumnetworks.com Date: Fri, 07 Oct 2016 14:14:02 +0200 Message-ID: <1717577.NEkDseq0hE@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1475772490-10491-3-git-send-email-bernard.iremonger@intel.com> References: <1475753191-17391-1-git-send-email-bernard.iremonger@intel.com> <1475772490-10491-3-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 12:14:07 -0000 2016-10-06 17:48, Bernard Iremonger: > call _rte_eth_dev_callback_process from ixgbe_rcv_msg_from_vf function. > > The callback asks the user application if it is allowed to perform > the function. > If the cb_param.retval is RTE_PMD_IXGBE_MB_EVENT_PROCEED then continue, > if 0, do nothing and send ACK to VF > if > 1, do nothing and send NAK to VF. [...] > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3559,7 +3559,7 @@ ixgbe_dev_interrupt_delayed_handler(void *param) > ixgbe_dev_link_update(dev, 0); > intr->flags &= ~IXGBE_FLAG_NEED_LINK_UPDATE; > ixgbe_dev_link_status_print(dev); > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC); > + _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); > } > > PMD_DRV_LOG(DEBUG, "enable intr in delayed handler S[%08x]", eicr); > @@ -7525,7 +7525,7 @@ static void ixgbevf_mbx_process(struct rte_eth_dev *dev) > > /* PF reset VF event */ > if (in_msg == IXGBE_PF_CONTROL_MSG) > - _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET); > + _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET, NULL); > } This piece should go into the patch 1.