From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id ED12493EE for ; Mon, 7 Dec 2015 03:04:35 +0100 (CET) Received: by wmec201 with SMTP id c201so132318331wme.1 for ; Sun, 06 Dec 2015 18:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=zqpwdqXXIFXK43Ig630znDRmCNyDhI234rur5Ou52Ic=; b=TizICXmllESLGXAdC8GWBaeg+H3RGHoQ1SBMg7hGgs5L8o4bXXD+1vv1E6YLB05Amm 6yKzibQvbxVlEc80HPKBAR0vTEPmgKpW3fJpAtP0NlllWoAUm+KKW9WKfqInhs16/P1T wOOfJfiWMPxXmXBn9kWxkVA4n2orjFxQuPNCR5phmCwzd7PHXUeA11Df7+NFD23Ph7WM h9H4I9C4svwBghXa9pUaCbka1JiZsVBm7tYIZiK23jnA8nx1RDDNxZ+ArGFbThiyYgik eH0Dz2JvfHUg0kWk51v2Dq08n4I8xfrk9s98H+zgs0DD37Xp7QgPyUhQ1vgAfOwWaymt nnzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zqpwdqXXIFXK43Ig630znDRmCNyDhI234rur5Ou52Ic=; b=O5xDa9x/BPe+n6/SBHP28ps88HSesm6aN68AZR0zlrKnrShJp90dy/UCz0nBOBZa92 yDdEVrb8UIpSoSdySWpujwQpHaAjtkPTkW3XCvWrL8AkDK9WNtXiQmM9Tr9rXoiivTPs M9knO/mud0pnDXswpLNAqXXAhVcKV5dE6EMCNASZR/D7fFfNL3dJOVnjqMGI5S/NJKep wIl4PVvQDyHBXiE3W/f2e99KWwAcfySJgPWihhjw672YtVruzJPOx6qfB6mX9ec+BS+n PIkHPKaps+c0pgbiYCszmY/hfkhM/PFWVoD/e/1HwSkvLfDq/TImM0J+uhqC8ZN5yPlV u/Og== X-Gm-Message-State: ALoCoQluaVedcDubCZNcRKR9QOFke5O/eaDC/XWoIdn9oFulNZeSXbY2bNJPUjHuWMnD1qXU2Wh3 X-Received: by 10.194.115.129 with SMTP id jo1mr30561452wjb.28.1449453875873; Sun, 06 Dec 2015 18:04:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id k125sm14252435wmf.2.2015.12.06.18.04.35 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Dec 2015 18:04:35 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Mon, 07 Dec 2015 03:03:24 +0100 Message-ID: <1717599.oECOgsfiks@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151207020035.GD29571@yliu-dev.sh.intel.com> References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <2679675.c6cKM9bBsr@xps13> <20151207020035.GD29571@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 02:04:36 -0000 2015-12-07 10:00, Yuanhan Liu: > On Mon, Dec 07, 2015 at 12:07:28AM +0100, Thomas Monjalon wrote: > > 2015-12-02 15:53, Panu Matilainen: > > > This (and other changes in patch 2 breaks the librte_vhost ABI again, so > > > you'd need to at least add a deprecation note to 2.2 to be able to do it > > > in 2.3 at all according to the ABI policy. > > > > > > Perhaps a better option would be adding some padding to the structs now > > > for 2.2 since the vhost ABI is broken there anyway. That would at least > > > give a chance to keep it compatible from 2.2 to 2.3. > > > > Please could you point where the vhost ABI is broken in 2.2? > > Thomas, here are the changes to rte_virtio_net.h: > > > $ git diff 381316f6a225139d22d39b5ab8d50c40607924ca..19d4d7ef2a216b5418d8edb5b004d1a58bba3cc1 \ > -- lib/librte_vhost/rte_virtio_net.h > [...] The problem is that the changes are not noticed in the release notes and the LIBABIVER is still 1.