From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D41801B3EE; Wed, 17 Apr 2019 09:55:35 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F4E3308339E; Wed, 17 Apr 2019 07:55:35 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60A0760143; Wed, 17 Apr 2019 07:55:26 +0000 (UTC) To: Ilya Maximets , dev@dpdk.org Cc: Tiwei Bie , Jens Freimann , Dariusz Stojaczyk , David Marchand , stable@dpdk.org References: <20190411102306.11943-1-i.maximets@samsung.com> From: Maxime Coquelin Message-ID: <17176142-811b-2fa4-d40f-8339d9f2fe0a@redhat.com> Date: Wed, 17 Apr 2019 09:55:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190411102306.11943-1-i.maximets@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 17 Apr 2019 07:55:35 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 07:55:36 -0000 On 4/11/19 12:23 PM, Ilya Maximets wrote: > Need to destroy allocated device if application fails to > add new connection or we have fdset failure. > > Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") > Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") > Cc:stable@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/socket.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 56411A00E6 for ; Wed, 17 Apr 2019 09:55:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24FF61B4F5; Wed, 17 Apr 2019 09:55:37 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D41801B3EE; Wed, 17 Apr 2019 09:55:35 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F4E3308339E; Wed, 17 Apr 2019 07:55:35 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60A0760143; Wed, 17 Apr 2019 07:55:26 +0000 (UTC) To: Ilya Maximets , dev@dpdk.org Cc: Tiwei Bie , Jens Freimann , Dariusz Stojaczyk , David Marchand , stable@dpdk.org References: <20190411102306.11943-1-i.maximets@samsung.com> From: Maxime Coquelin Message-ID: <17176142-811b-2fa4-d40f-8339d9f2fe0a@redhat.com> Date: Wed, 17 Apr 2019 09:55:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190411102306.11943-1-i.maximets@samsung.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 17 Apr 2019 07:55:35 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417075524._IWPNDSFHju5LF-F1KZ9tWL9wPOjQ-uGWqiSnlsnjiA@z> On 4/11/19 12:23 PM, Ilya Maximets wrote: > Need to destroy allocated device if application fails to > add new connection or we have fdset failure. > > Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") > Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") > Cc:stable@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/socket.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime