From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99F54A0C43; Thu, 30 Sep 2021 18:55:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E60E3410E5; Thu, 30 Sep 2021 18:55:32 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A571640DDA for ; Thu, 30 Sep 2021 18:55:30 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 494475C019D; Thu, 30 Sep 2021 12:55:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 30 Sep 2021 12:55:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 20NCYnK28R8RdLNx6tW3rS/zhVD+PMXGPAAs9BygVIY=; b=i3CU3hZKxr0SLiMh 2E1l3LG4r/CXbRWD/+tQWkV0cexGB8fl+mtEzpAYTZ/SaBrpLxRscRY6jALuieKe OMuLN7Az2idrj8OxXUlmiAcSyc3uLjKqmtm0vU88y0jWWZfFfnTa+YJraeruZoq6 tvp6Q+TNJRgBAfn3qNkRJ85wAOJhcHZh4dVRYzvNpr8Rts5578f22FZz80Lcczdf A1uoKklEJjgAOfPHjTr0Os/0gtFpybAu8O30UU/nyhHIk/Tyf9YIJfP48JScpAPu FxKV24+qdxR+edAzxT1MMo/e7bZDm/166RqUIsjP6pTJiKlexRHhxMllpkun/ns9 nRclaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=20NCYnK28R8RdLNx6tW3rS/zhVD+PMXGPAAs9BygV IY=; b=hcgy+4EMqidA4/ZR3Yh3IEuD/BNs+sv7r5PbsPp9ffSNRskQ0EDd8WRCV AK/GrCoxAqn411+4AbDjs0o9LKV9YqW/M9izXMsuaqNnXtXwHgD36bRb+dkLZq53 N2GfuzeYxsu0+dz8YY76z8c3JxYyG7hGa5xT311W6wkrjPzkB3reuHBnJHtvnX5k FPgbxmijNP0yqhKGl5fwxgm5J6/g8MlbBEylHtOjS3Yg9H1Fj3yewxR0rzr4cQne PhWgZFsyItAez3Che0ok6snPfW7ruHyPwVRk/9FtsyjSU6RJEIsUC4ImQEtfnOKb LFyz7/i/204BrykwsAzyZezWgc1RQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekgedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejkeegteffieetkeehueeggefhteekueektdeffeekffdvvddu uefhgfffiefgveenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj rghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Sep 2021 12:55:29 -0400 (EDT) From: Thomas Monjalon To: Srikanth K Cc: Matan Azrad , Viacheslav Ovsiienko , dev@dpdk.org, Vag Singh , Anand Thulasiram , asafp@nvidia.com, shys@nvidia.com Date: Thu, 30 Sep 2021 18:55:27 +0200 Message-ID: <1717629.XB9YD5fsJO@thomas> In-Reply-To: References: <20210927133450.10653-1-srikanth.k@oneconvergence.com> <3498914.nWIOhJD1b8@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/09/2021 18:27, Srikanth K: > Sure, I will follow the Windows support approach. > > Regarding the patches organization, they were arranged logically to the > best of my knowledge. It is not. > The approach followed is to take Linux PMD code and replace the Linux > dependent part with the > FreeBSD compatible code. All the removals are of this Linux dependent code. The removals are in the directory drivers/net/mlx5/freebsd/ That's simple: don't add code that you remove later. > For the same reason, > FreeBSD meson support is added in the last patch or otherwise Linux code > would break compilation > in FreeBSD. Simple: add only code which compiles. > The patches status is still "New" on the DPDK site, please let me know when > I can submit the next version. You can submit new versions and mark old ones as superseded. The full process is described in the contributing guide, please read it carefully. > On Wed, Sep 29, 2021 at 9:50 PM Thomas Monjalon wrote: > > > 29/09/2021 17:56, Srikanth K: > > > Hi Thomas, > > > > > > PFA the test report. It covers all the features that were tested across > > > various platforms. > > > > > > The features mentioned in the test report depend on a modified FreeBSD > > > OFED. There is an ongoing review of these changes by the FreeBSD > > community. > > > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/ > > > > OK, this dependency is very important to notify in this patchset. > > For next version, please add it in the cover letter. > > > > The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats > > and trust mode) should be listed in the cover letter as well as > > in the mlx5 documentation. Please follow what was done for Windows. > > > > About the patches organization, please do not fix or remove something > > which was added in a previous patch. You need to have logical steps > > done in each patch without going backward. > > Please start with enabling compilation in first patch, > > so each step can be tested. > > > > Thanks > > > > > > >