From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 5F3F43237 for ; Thu, 28 Jul 2016 18:05:53 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id o80so115178514wme.1 for ; Thu, 28 Jul 2016 09:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=IR+lD/wyteYJqaW1cR4RQBtihkfPVIZtqMgj9Tif38E=; b=MA5zVwROuiHWW4UBrvet9bMEv0NeP9ynZJZK9ke9WXbdDr8Q5QQUCICdh3W8aLblom nqq41J4OvKHPFl1eRFqdBVMNcNdvoPUqws+qAwqn7+Bb0x338enYfK+UwRX0GIpqpLB8 l+ghtN5E0s4FTkiR/JrVt2F6jhvpXP4AZDzJqkQGU23N9YjjyUuiRBBKGQm90e+4T04Y 6b6Dzb8csvLJCnEzxpAM3B0Vb6Wcwyu2XlVmcy/wqIoFDaE20akF6nE/WYf6pKAj/W00 B0ULzvDFhJX798cahMonJXra99VWB/duBQvabvFkvG1KewTajqua0kqJpEq0cETEPoU0 pL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=IR+lD/wyteYJqaW1cR4RQBtihkfPVIZtqMgj9Tif38E=; b=BvI+6og+Vd1WFJGbdBCSZTHDM5XhrlKe7zcLksdvapxY9puhrKPSM9AeetKjdM6gNd 5/TNa7ziKJe1I1grPLUMwWIobXWTtSN1ec98SEf0+gWOJkqOEk0mH90epWMrkVpLZ1Q9 8L6vDyTluZ/4l66nyDkb8X8rmTYSTg6pi4D9yf4jpkhaCmnprbkqTKHsu8bXKxKsaK6F zRO9OD49ke4wGSs7An9dxl/IFAYfb5hDLtMNNOPXcT0JP+kgv5SH6WgLZSox8ed/tpnO kLIU2h//nZp00LUNNlm2Yn4eXrc5soy8jyOrHaUT6ddoXIqXWlm8UC0LyW+SxQdGWlIQ 1UuA== X-Gm-Message-State: AEkoousRtt6vRadaF4qnPbm/Lg4b7gfDREGf+QaTAhq/T0QeWAklK7RMSF0JBfHjrtlXm96l X-Received: by 10.194.11.102 with SMTP id p6mr33890243wjb.104.1469721953130; Thu, 28 Jul 2016 09:05:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id n7sm12202053wjf.11.2016.07.28.09.05.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jul 2016 09:05:52 -0700 (PDT) From: Thomas Monjalon To: Wei Dai Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 28 Jul 2016 18:05:51 +0200 Message-ID: <1717702.2SVR8RdYDI@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <579A2433.1060701@intel.com> References: <1469081018-55300-1-git-send-email-wei.dai@intel.com> <1469618870-144592-1-git-send-email-wei.dai@intel.com> <579A2433.1060701@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --lcores argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2016 16:05:53 -0000 2016-07-28 16:26, Ferruh Yigit: > On 7/27/2016 12:27 PM, Wei Dai wrote: > > With --lcores 'a-b@c-d', eal_parse_cores() fails because > > eal_parse_set() fails due to the next character after > > lcore set a-b, which is '@'and not ',' or '\0'. > > There is also a right check immediately > > after this incorrect check. > > > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > > > Signed-off-by: Wei Dai > > I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is > supported and already working. Agreed. Series applied, except this last patch 4, thanks