From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/eventdev: fix build with GCC < 5
Date: Sun, 21 Jan 2018 23:41:58 +0100 [thread overview]
Message-ID: <1717907.XnPDdZBNct@xps> (raw)
In-Reply-To: <ef91eaae-4768-1fd0-fc00-88fee652e18d@intel.com>
21/01/2018 23:40, Ferruh Yigit:
> On 1/21/2018 10:32 PM, Thomas Monjalon wrote:
> > Forgot the Fixes: tags,
> >
> > 21/01/2018 23:21, Thomas Monjalon:
> >> Some errors were seen with GCC 4.8 and 4.9.
> >> It looks to be a bug fixed in GCC 5.
> >>
> >> examples/eventdev_pipeline/pipeline_worker_generic.c:474:4: error:
> >> missing initializer for field 'queue_id' of 'struct <anonymous>'
> >>
> >> examples/eventdev_pipeline/pipeline_worker_generic.c:475:3: error:
> >> missing initializer for field 'priority' of 'struct <anonymous>'
> >>
> >> examples/eventdev_pipeline/pipeline_worker_tx.c:630:2: error:
> >> missing initializer for field 'queue_id' of 'struct <anonymous>'
> >>
> >> The workaround is to not use initializer statement,
> >> but to use memset and standard assignment.
> >
> > Fixes: 84dde5de10a2 ("examples/eventdev: support Rx adapter")
> > Fixes: fa8054c8c889 ("examples/eventdev: add thread safe Tx worker pipeline")
> >
> >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied
prev parent reply other threads:[~2018-01-21 22:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 22:21 Thomas Monjalon
2018-01-21 22:32 ` Thomas Monjalon
2018-01-21 22:40 ` Ferruh Yigit
2018-01-21 22:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1717907.XnPDdZBNct@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).