From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Ousterhout <ouster@cs.stanford.edu>
Cc: dev@dpdk.org, david.marchand@6wind.com
Subject: Re: [dpdk-dev] [PATCH] log: respect rte_openlog_stream calls before rte_eal_init
Date: Fri, 30 Sep 2016 17:01:33 +0200 [thread overview]
Message-ID: <17179105.NJRITsrcxm@xps13> (raw)
In-Reply-To: <20160928204244.8288-1-ouster@cs.stanford.edu>
2016-09-28 13:42, John Ousterhout:
> Before this patch, rte_eal_init invoked rte_openlog_stream, cancelling
> any application-specific logger and making it it impossible for an
> application to capture the initial log messages generated during
> rte_eal_init. With this patch, applications can capture all of the
> log messages.
It deserves an explanation of what the patch does, i.e. the new logic.
If think you just want to remove the log init from rte_eal_init and
use the default stream when it is not initialized (NULL).
You could also remove the early log stream since the default one could
work from the early stage. Indeed the complex log history was removed:
http://dpdk.org/commit/a3f34a98
Thanks for improving the usability.
next prev parent reply other threads:[~2016-09-30 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 20:42 John Ousterhout
2016-09-30 15:01 ` Thomas Monjalon [this message]
2016-10-10 22:39 ` [dpdk-dev] [PATCH v2] " John Ousterhout
2016-10-11 8:08 ` Thomas Monjalon
2016-10-11 16:30 ` John Ousterhout
2016-10-11 20:30 ` Thomas Monjalon
2016-10-11 21:46 ` John Ousterhout
2016-10-12 7:09 ` Thomas Monjalon
2016-10-11 22:16 ` Don Provan
2016-10-12 0:22 ` John Ousterhout
2016-10-12 19:29 ` [dpdk-dev] [PATCH v3] " John Ousterhout
2016-10-12 19:38 ` [dpdk-dev] [PATCH v4] " John Ousterhout
2016-10-12 19:47 ` Thomas Monjalon
2016-10-12 21:17 ` John Ousterhout
2016-10-13 20:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17179105.NJRITsrcxm@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ouster@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).