DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jun Wang <junwang01@cestc.cn>
To: dev@dpdk.org
Subject: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert
Date: Wed, 12 Jun 2024 15:05:43 +0800	[thread overview]
Message-ID: <1718175943-3586-1-git-send-email-junwang01@cestc.cn> (raw)

When encountering errors in handling some queues, we should assert
here; otherwise, some queues will fail to send packets continuously,
leading to traffic forwarding issues.

Bugzilla ID: 1449

Signed-off-by: Jun Wang <junwang01@cestc.cn>
---
 drivers/net/mlx5/mlx5_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
index 1fe9521..e149f38 100644
--- a/drivers/net/mlx5/mlx5_tx.c
+++ b/drivers/net/mlx5/mlx5_tx.c
@@ -213,7 +213,7 @@
 				 * handling, we do not advance the index
 				 * here, allowing to retry on next call.
 				 */
-				return;
+				MLX5_ASSERT(ret < 0);
 			}
 			/*
 			 * We are going to fetch all entries with
-- 
1.8.3.1




                 reply	other threads:[~2024-06-12  7:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1718175943-3586-1-git-send-email-junwang01@cestc.cn \
    --to=junwang01@cestc.cn \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).