From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC663424DA; Wed, 12 Jun 2024 09:05:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75FF740B91; Wed, 12 Jun 2024 09:05:55 +0200 (CEST) Received: from smtp.cecloud.com (unknown [1.203.97.240]) by mails.dpdk.org (Postfix) with ESMTP id E7AB5402AB for ; Wed, 12 Jun 2024 09:05:53 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by smtp.cecloud.com (Postfix) with ESMTP id 5A139900116 for ; Wed, 12 Jun 2024 15:05:51 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from izgc79c142y6tt9fty3vzrz.localdomain (unknown [47.122.22.90]) by smtp.cecloud.com (postfix) whith ESMTP id P3932314T281457058640240S1718175945417209_; Wed, 12 Jun 2024 15:05:51 +0800 (CST) X-RL-SENDER: junwang01@cestc.cn X-SENDER: junwang01@cestc.cn X-LOGIN-NAME: junwang01@cestc.cn X-FST-TO: dev@dpdk.org X-RCPT-COUNT: 1 X-LOCAL-RCPT-COUNT: 0 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 47.122.22.90 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: <8716e72c19ef30977240a3addf458bec> X-System-Flag: 0 From: Jun Wang To: dev@dpdk.org Subject: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert Date: Wed, 12 Jun 2024 15:05:43 +0800 Message-Id: <1718175943-3586-1-git-send-email-junwang01@cestc.cn> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When encountering errors in handling some queues, we should assert here; otherwise, some queues will fail to send packets continuously, leading to traffic forwarding issues. Bugzilla ID: 1449 Signed-off-by: Jun Wang --- drivers/net/mlx5/mlx5_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c index 1fe9521..e149f38 100644 --- a/drivers/net/mlx5/mlx5_tx.c +++ b/drivers/net/mlx5/mlx5_tx.c @@ -213,7 +213,7 @@ * handling, we do not advance the index * here, allowing to retry on next call. */ - return; + MLX5_ASSERT(ret < 0); } /* * We are going to fetch all entries with -- 1.8.3.1