From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6343A04B6; Sun, 11 Oct 2020 22:06:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B195B1D55E; Sun, 11 Oct 2020 22:06:15 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CF7381D155; Sun, 11 Oct 2020 22:06:12 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2425E5C0085; Sun, 11 Oct 2020 16:06:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 11 Oct 2020 16:06:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= WYpHHLu7vQxSJ6j8yNdF22N6HspoIhWalWETzNY+FgI=; b=gqWpUdPGDOIHmnEB kUqLj8w7C7SrZ6kxKW1ghnA7c9Wn3yUKUtA0Lr3E5CUpyjdjZS5QeVpvMJwfxaKR AC6H7TF1yyxlm0sbbRo82VZ6I9Ft/stilyAgNcOMkT0a5bLRIHNirHMMdXYhi10O G8Z5k48mWoSyighPOifZsCtROrOe59+jA6P+8MYG3AmvytB5OsELO8zAKTbnEdJ3 HCYL23qleAHvOvxEECD5L5sx9kZSA8z3j+hq63PQMVc4BXvY7BWvSV7rGgnYkmpJ qlU3GSuXFvuko5EBQtMQ4k02VQU7UPuvX9K4NwmtwkaphXhFwBgunCHxvkCuuCZ0 TVlQ1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WYpHHLu7vQxSJ6j8yNdF22N6HspoIhWalWETzNY+F gI=; b=Am+KeIZPD/6JIO5K69zTvshQ79EKpNg4f6U6zOQ4v1yf7S2xjagZWO7aj 2vPzBlXcLau0/XjRcvGaraxZUBg4s/uOIrh+0/8fCeTA45BXnZn8HkwATc5zljJx NK9SbNNuU4zqPcClIUPYjr5KXh8lPPawjTYOWocMNEcca3CwLB4RSA2hqTttKWT1 9vU87r8vs4cp35zafWtEPNlm7gyTxe916O/gvhFzMeQU7xua7zKRNY6K/EfcKenx fCOUXe6GJeFAi6ujb6/9ldHc7H8aednPEtvPp8uyhjmdkph/cKYMUjEvguT1s8tt Szgcq6WR6OqTPgBewIPlByaXoqebw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheehgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DFF45328005A; Sun, 11 Oct 2020 16:06:09 -0400 (EDT) From: Thomas Monjalon To: wangyunjian , Nipun Gupta Cc: "dev@dpdk.org" , stable@dpdk.org, "jerry.lilijun@huawei.com" , "xudingke@huawei.com" Date: Sun, 11 Oct 2020 22:06:06 +0200 Message-ID: <1718706.bEVi5a3gDK@thomas> In-Reply-To: References: <8f778cef6a01a8222e256daf25ff5ce6feed334b.1599485594.git.wangyunjian@huawei.com> <1599613906-19420-1-git-send-email-wangyunjian@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > This issue detected by coverity, CID#279443(Structurally dead code). > > > > Coverity issue: 279443 > > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang > > --- > > --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > > +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c > > @@ -452,9 +452,10 @@ rte_qdma_reset(void) > > /* In case there are pending jobs on any VQ, return -EBUSY */ > > for (i = 0; i < qdma_dev.max_vqs; i++) { > > if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues != > > - qdma_vqs[i].num_dequeues)) > > + qdma_vqs[i].num_dequeues)) { > > DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", > > i); > > return -EBUSY; > > + } > > } Acked by: Nipun Gupta I don't understand how it could work before in simplest case. Changed title to "fix reset". Applied, thanks