From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7474541CE4; Sun, 19 Feb 2023 23:43:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13DE342D61; Sun, 19 Feb 2023 23:43:07 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 1BF0942D5E; Sun, 19 Feb 2023 23:43:05 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B225F5C0138; Sun, 19 Feb 2023 17:43:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 19 Feb 2023 17:43:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676846584; x= 1676932984; bh=MCVcuKU7a34xANCG6hKFHDyxR1l+ZN48Wu2Vy9tQbeo=; b=C dUr5EGdCSW53n6qykhuja/EKElSUbQPHeZgJY6x4qYNL2o3eD1vhXENt5A4DK6jp YJHK3Jae9G+sVGR3DT3oItL5t8DuzHMxDmpxs9ZlTDJM0X47/Jl7EGsPoWFM6H1K Q1r48ZBt8a9F9It4LcUjWs+lwznXNyIvT/p1gTWLCeOo3L4QlVQkIW03t1KAOXa+ UrqeY5HW7GMxuLZqtPfe2ESbJpF4r8z10unsLQbCeiw5lB6fd9GDfg1eFx3KySwG DT8Cv7MZZVrzYvuFBaR0yLAR+SkLgdXWOw0kf9afzk884ZHFoCDgFYJvfWJsKyOw B4Ey+U0XREKrxMksMwE7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676846584; x= 1676932984; bh=MCVcuKU7a34xANCG6hKFHDyxR1l+ZN48Wu2Vy9tQbeo=; b=Q csxOL51qN8f6ty4SoY3JoYVoEj5a/KjEm5qD6TwBSVCuwuNWKeTNLX+/5xo9o9oP CDl2Y6qyRMpP5ZK98JxFDOtFcMrdFpDiS2Mb9M2YEcoUMNx+IIOfLaC0VQ+40VoC oR8JIFuHO8msYDJUm3c+8u++Oirwpkkwg865OAk92aosDCUWEDi5vA6GSl2wLMv8 cfZyRaoMMUNNBRQX61zVd9bvRVCAwuKb8VZimJwUR10EYKU4HjLR7nQmd+RB290f cgDoPG62BlA6NRh9wFlr58PQ1N4eZxVbfFrqB899zDKg8hytukXBOMkdlGFPJLwi 6tNHUyASUahzKd3N+kFbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgudeiiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 17:43:03 -0500 (EST) From: Thomas Monjalon To: Megha Ajmera Cc: stable@dpdk.org, dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, david.marchand@redhat.com Subject: Re: [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport Date: Sun, 19 Feb 2023 23:43:02 +0100 Message-ID: <1720004.jNaZZp9DzI@thomas> In-Reply-To: <11894451.zAa99ISigo@thomas> References: <20230207061008.773757-1-megha.ajmera@intel.com> <11894451.zAa99ISigo@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/02/2023 23:40, Thomas Monjalon: > 07/02/2023 07:10, Megha Ajmera: > > Big structures like bitmap, pipes and queues in subport are addressed > > using offset of 'memory' field in subport structures. This means no other > > variable should be added after 'memory' variable or else addressing of such > > structs like bitmap etc. become incorrect. > > > > Realigned tc_ov_enabled variable in subport structure. > > > > Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally") > > > > Signed-off-by: Megha Ajmera > > Acked-by: Cristian Dumitrescu > > I bet the impact is wrongly explained, but I don't want to look deeper. > Applied. And I've added Cc: stable@dpdk.org that David and Cristian asked for.