From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E87742C40; Tue, 6 Jun 2023 15:43:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AC2E40697; Tue, 6 Jun 2023 15:43:34 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 9C8B640223 for ; Tue, 6 Jun 2023 15:43:33 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 246655C01BF; Tue, 6 Jun 2023 09:43:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 06 Jun 2023 09:43:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686059013; x=1686145413; bh=Iny6D9eD+U2iYDoIzBvYIBdYBSl/qQR/A8l cciY6+a4=; b=gD13FltiWulz7v23A5N5+OifFiWb9tLlHiFPf1WAdfvNe1/E5e6 Xsz4eFUEcF6yMe1fMrlQC75hATK5yYLBam/8J0P3BVjpxMvfb7yNTk0LcQ/v4V/H VTR+mCqIQVPbYCB0xKo/l6szvGPjNXgXzNQGdoKjUdd+CjY8/GsTUfWKquF8uvgR 03w7qKLRT3W/MK2YbnBl6BuM386SS4Ov7ulnBxB6ObEGEVQe9IiiNewOLKZ2QHxB poHenU55nij6GvRveCF3GIfAy8hOQESb2X/kIKQqUVjpDZOh0koXdJcXYagthB4n E6ug21E+k4lFg5nMzKp13AEYuSg47ua9AcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686059013; x=1686145413; bh=Iny6D9eD+U2iYDoIzBvYIBdYBSl/qQR/A8l cciY6+a4=; b=che0RX05nR4zBk1iUDIJF/H+BOr+AbPLO3vZPvNQWD8/7GzbywX vNOP/I5RnIQvPVkTyQ9XUHSPBWcP0QJy4OlGndAx45Hzbi7/+t3IMHsh9J9t/DRl /EHw27NH7I8ZtPHmrnmFBDc3j4XTugt1GCTNkAtMj2UAYHvn0nj34Myil3ddiz7A fPidefM5li61uTiff8rpMo6Q4rTyTge4hXRF5rpU1p8NAKP6EiC9I4dJ2gbOnjBq 7vo89akJelYoQ9Q49hhgMzlnC0Neshgad67CYPKVt0Kl8uKKW0upM2Y9P3BAjAuv /dwX9An20TI+3gX8TBfR/5+iUVts11Pc7WQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtuddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Jun 2023 09:43:31 -0400 (EDT) From: Thomas Monjalon To: Nipun Gupta Cc: dev@dpdk.org, david.marchand@redhat.com, hkalra@marvell.com, anatoly.burakov@intel.com, stephen@networkplumber.org, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com Subject: Re: [PATCH v7 1/4] bus/cdx: introduce AMD CDX bus Date: Tue, 06 Jun 2023 15:43:30 +0200 Message-ID: <17207268.5WZRyvrzyv@thomas> In-Reply-To: <3826f910-7347-bd6a-c71c-278bab759417@amd.com> References: <20230124140746.594066-1-nipun.gupta@amd.com> <3464713.L4jQFfv3LO@thomas> <3826f910-7347-bd6a-c71c-278bab759417@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/06/2023 15:38, Nipun Gupta: > > On 6/6/2023 6:30 PM, Thomas Monjalon wrote: > > > > 06/06/2023 12:02, Nipun Gupta: > >> +/* Forward declarations */ > >> +struct rte_cdx_device; > >> +struct rte_cdx_driver; > >> +struct rte_cdx_bus; > > > > You should be very careful about what you export. > > > >> + > >> +#define CDX_BUS_DEVICES_PATH "/sys/bus/cdx/devices" > > > > This define is not needed in the .h file. > > This is required and used by some of the out of tree CDX drivers which > are developed by the customers, so it is needed here. In this case, it should be prefixed with RTE_ > > > >> + > >> +#define CDX_MAX_RESOURCE 4 > > > > This size looks required for rte_cdx_device, > > but as an exported constant, it should be prefixed with RTE_ > > Sure, will update. > > Thanks, > Nipun > > > > >> + > >> +/** Any CDX device identifier (vendor, device). */ > >> +#define RTE_CDX_ANY_ID (0xffff) > > > > > > >