* [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code
@ 2017-07-28 8:10 Zhiyong Yang
2017-07-31 14:42 ` Gaëtan Rivet
0 siblings, 1 reply; 3+ messages in thread
From: Zhiyong Yang @ 2017-07-28 8:10 UTC (permalink / raw)
To: dev; +Cc: thomas, Zhiyong Yang
The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
in the function rte_eth_copy_pci_info(), remove it here.
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
lib/librte_ether/rte_ethdev_pci.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h
index c3f7f721c..fe2e0f64c 100644
--- a/lib/librte_ether/rte_ethdev_pci.h
+++ b/lib/librte_ether/rte_ethdev_pci.h
@@ -117,7 +117,6 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)
}
eth_dev->device = &dev->device;
- eth_dev->intr_handle = &dev->intr_handle;
rte_eth_copy_pci_info(eth_dev, dev);
return eth_dev;
}
--
2.13.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code
2017-07-28 8:10 [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code Zhiyong Yang
@ 2017-07-31 14:42 ` Gaëtan Rivet
2017-07-31 15:04 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Gaëtan Rivet @ 2017-07-31 14:42 UTC (permalink / raw)
To: Zhiyong Yang; +Cc: dev, thomas
Hi Zhiyong,
On Fri, Jul 28, 2017 at 04:10:14PM +0800, Zhiyong Yang wrote:
> The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
> in the function rte_eth_copy_pci_info(), remove it here.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_ether/rte_ethdev_pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h
> index c3f7f721c..fe2e0f64c 100644
> --- a/lib/librte_ether/rte_ethdev_pci.h
> +++ b/lib/librte_ether/rte_ethdev_pci.h
> @@ -117,7 +117,6 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)
> }
>
> eth_dev->device = &dev->device;
> - eth_dev->intr_handle = &dev->intr_handle;
> rte_eth_copy_pci_info(eth_dev, dev);
> return eth_dev;
> }
> --
> 2.13.3
>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code
2017-07-31 14:42 ` Gaëtan Rivet
@ 2017-07-31 15:04 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-07-31 15:04 UTC (permalink / raw)
To: Zhiyong Yang; +Cc: Gaëtan Rivet, dev
31/07/2017 16:42, Gaëtan Rivet:
> Hi Zhiyong,
>
> On Fri, Jul 28, 2017 at 04:10:14PM +0800, Zhiyong Yang wrote:
> > The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
> > in the function rte_eth_copy_pci_info(), remove it here.
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-31 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-28 8:10 [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code Zhiyong Yang
2017-07-31 14:42 ` Gaëtan Rivet
2017-07-31 15:04 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).