DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/gve: Update TX queue state
@ 2024-07-22 11:10 Tathagat Priyadarshi
  2024-07-22 14:11 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Tathagat Priyadarshi @ 2024-07-22 11:10 UTC (permalink / raw)
  To: rushilg, joshwash; +Cc: dev, Tathagat Priyadarshi

Fixing Typo in updating the TX queue state

Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
---
 drivers/net/gve/gve_tx.c     | 2 +-
 drivers/net/gve/gve_tx_dqo.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
index 70d3ef0..500ae31 100644
--- a/drivers/net/gve/gve_tx.c
+++ b/drivers/net/gve/gve_tx.c
@@ -688,7 +688,7 @@
 
 	rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
 
-	dev->data->rx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
+	dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
 
 	return 0;
 }
diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
index a65e6aa..1b85557 100644
--- a/drivers/net/gve/gve_tx_dqo.c
+++ b/drivers/net/gve/gve_tx_dqo.c
@@ -392,7 +392,7 @@
 
 	rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
 
-	dev->data->rx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
+	dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
 
 	return 0;
 }
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/gve: Update TX queue state
  2024-07-22 11:10 [PATCH] net/gve: Update TX queue state Tathagat Priyadarshi
@ 2024-07-22 14:11 ` Ferruh Yigit
  2024-07-22 14:19   ` Tathagat Priyadarshi
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2024-07-22 14:11 UTC (permalink / raw)
  To: Tathagat Priyadarshi, rushilg, joshwash; +Cc: dev

On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote:
> Fixing Typo in updating the TX queue state
> 
> Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
>

Good catch, thanks Tathagat.

I think impact is more than just typo, so let me update the patch title as:

net/gve: fix Tx queue state on queue start

Also needs fixes tag:
 Fixes: b044845bb015 ("net/gve: support queue start/stop")
 Cc: stable@dpdk.org

With above changes,
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.

> ---
>  drivers/net/gve/gve_tx.c     | 2 +-
>  drivers/net/gve/gve_tx_dqo.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
> index 70d3ef0..500ae31 100644
> --- a/drivers/net/gve/gve_tx.c
> +++ b/drivers/net/gve/gve_tx.c
> @@ -688,7 +688,7 @@
>  
>  	rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
>  
> -	dev->data->rx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
> +	dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
>  
>  	return 0;
>  }
> diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
> index a65e6aa..1b85557 100644
> --- a/drivers/net/gve/gve_tx_dqo.c
> +++ b/drivers/net/gve/gve_tx_dqo.c
> @@ -392,7 +392,7 @@
>  
>  	rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
>  
> -	dev->data->rx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
> +	dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
>  
>  	return 0;
>  }


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/gve: Update TX queue state
  2024-07-22 14:11 ` Ferruh Yigit
@ 2024-07-22 14:19   ` Tathagat Priyadarshi
  0 siblings, 0 replies; 3+ messages in thread
From: Tathagat Priyadarshi @ 2024-07-22 14:19 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: rushilg, joshwash, dev

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

Thanks Ferruh.

On Mon, Jul 22, 2024 at 7:41 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote:
> > Fixing Typo in updating the TX queue state
> >
> > Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
> >
>
> Good catch, thanks Tathagat.
>
> I think impact is more than just typo, so let me update the patch title as:
>
> net/gve: fix Tx queue state on queue start
>
> Also needs fixes tag:
>  Fixes: b044845bb015 ("net/gve: support queue start/stop")
>  Cc: stable@dpdk.org
>
> With above changes,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Applied to dpdk-next-net/main, thanks.
>
> > ---
> >  drivers/net/gve/gve_tx.c     | 2 +-
> >  drivers/net/gve/gve_tx_dqo.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
> > index 70d3ef0..500ae31 100644
> > --- a/drivers/net/gve/gve_tx.c
> > +++ b/drivers/net/gve/gve_tx.c
> > @@ -688,7 +688,7 @@
> >
> >       rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
> >
> > -     dev->data->rx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> > +     dev->data->tx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> >
> >       return 0;
> >  }
> > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
> > index a65e6aa..1b85557 100644
> > --- a/drivers/net/gve/gve_tx_dqo.c
> > +++ b/drivers/net/gve/gve_tx_dqo.c
> > @@ -392,7 +392,7 @@
> >
> >       rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr);
> >
> > -     dev->data->rx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> > +     dev->data->tx_queue_state[tx_queue_id] =
> RTE_ETH_QUEUE_STATE_STARTED;
> >
> >       return 0;
> >  }
>
>

[-- Attachment #2: Type: text/html, Size: 2593 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-22 14:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-22 11:10 [PATCH] net/gve: Update TX queue state Tathagat Priyadarshi
2024-07-22 14:11 ` Ferruh Yigit
2024-07-22 14:19   ` Tathagat Priyadarshi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).