DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
To: rushilg@google.com, joshwash@google.com
Cc: dev@dpdk.org, Tathagat Priyadarshi <tathagat.dpdk@gmail.com>,
	Varun Lakkur Ambaji Rao <varun.la@gmail.com>
Subject: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain
Date: Wed, 31 Jul 2024 16:38:21 +0000	[thread overview]
Message-ID: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> (raw)

The EOP bit was not set for all the packets in mbuf chain
causing packet transmission stalls for packets split across
mbuf in chain.

Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
Signed-off-by: Varun Lakkur Ambaji Rao <varun.la@gmail.com>

Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
---
 drivers/net/gve/gve_tx_dqo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
index a65e6aa..579b8d6 100644
--- a/drivers/net/gve/gve_tx_dqo.c
+++ b/drivers/net/gve/gve_tx_dqo.c
@@ -126,6 +126,7 @@
 			txd->pkt.dtype = GVE_TX_PKT_DESC_DTYPE_DQO;
 			txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id);
 			txd->pkt.buf_size = RTE_MIN(tx_pkt->data_len, GVE_TX_MAX_BUF_SIZE_DQO);
+			txd->pkt.end_of_packet = 0;
 
 			/* size of desc_ring and sw_ring could be different */
 			tx_id = (tx_id + 1) & mask;
-- 
1.8.3.1


             reply	other threads:[~2024-07-31 16:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 16:38 Tathagat Priyadarshi [this message]
2024-07-31 20:30 ` Joshua Washington
2024-08-01 10:23   ` Tathagat Priyadarshi
2024-08-01 11:16 ` Ferruh Yigit
2024-08-01 16:24   ` Joshua Washington
2024-08-01 17:50     ` Tathagat Priyadarshi
2024-08-01 11:31 ` [PATCH v2] " Tathagat Priyadarshi
2024-08-01 17:27 ` [PATCH v3] net/gve : Update EOP & csum " Tathagat Priyadarshi
2024-08-01 18:54   ` Stephen Hemminger
2024-08-01 18:58     ` Tathagat Priyadarshi
2024-08-01 17:48 ` [PATCH v4] " Tathagat Priyadarshi
2024-08-02  5:08 ` [PATCH v5] " Tathagat Priyadarshi
2024-08-02  5:10   ` Tathagat Priyadarshi
2024-08-06 14:44     ` Tathagat Priyadarshi
2024-08-07  7:36       ` Ferruh Yigit
2024-08-07  9:39   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com \
    --to=tathagat.dpdk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=joshwash@google.com \
    --cc=rushilg@google.com \
    --cc=varun.la@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).