From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F7945702; Wed, 31 Jul 2024 18:37:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D742427BF; Wed, 31 Jul 2024 18:37:07 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 101A440EE7 for ; Wed, 31 Jul 2024 18:37:06 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1fec34f94abso44632175ad.2 for ; Wed, 31 Jul 2024 09:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722443825; x=1723048625; darn=dpdk.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h8NnWMUMov0zrv1WWx643QzzAjturLNrYXtdri0Vndc=; b=O9emnhTMzSZ2f+B6cmH77yN/+W/SJ/QtamqihTeRG2lRcpJAac54kj5k1cuK8a+j3j IHTBZ0xA9wfv2E0HtHU7bV8dSLxodP2eoPbmlOnhbtjXgm2YgeRYhZzIqObu5HQtxPnw +ObfNVGBwDqKOChpYmY8sd/KzAJh0jJB2AqPgkcM6B+6I3Ln6QldeiyjrxE2aw9Ot5OS 35+4j6y5Utb0yOBH822UP20yhxxgjk7eitRts5Iu3nmzUFQ2OW4I5TzyYWgMH0YK7Tjf hegYK3e1EmBbEs1a4EUXxTPRdPXGsRVfVnoKzR+uWDvgITLOv3lY50sWnSz9opjrMbvJ s0dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722443825; x=1723048625; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8NnWMUMov0zrv1WWx643QzzAjturLNrYXtdri0Vndc=; b=neyp0VXSvcK2VqbzAV+XoXUYwHJDTJ8auAHghuzZIBNynOJkXbnFRHWKLf3wtjCRDK bECyct50fTEPtRU4o5QvNThSsfdalqZpZWdFmaQ78Sm8OMdVb0cH7mQM83y+X4HbK3ts 7vP9IGq8dPa78AO80Rb7o8qXo5gOtSWUtDN8Ol0kehf8gbYtAFoZ+yTJlrxjsa9OUH+u kos6KAIRBVVoPhZQi7c9JVjUVPIXmNGG+4oRE9aQRunpfMY9+MVBJsSJADqHH/yEkBtF CDBYr2/0gaMMr0dpM9J2a88uvHq5w4Or66IOw1UBIb/QyEZwPq1CG5VUw3W1Zifcw0TL rQ/A== X-Gm-Message-State: AOJu0YxPa+c2AgmvaQbyGkKVy5oZC6NOc4Q3ZAr2YXmjuvtHV/SGf6Js 4iwlwWstP1jRduwCwm6bW41JC920iqT8ZjN6XRiW8ZHsYuYmqiXK X-Google-Smtp-Source: AGHT+IHhLuqAWxTDOdVCdRT+xBV+cWlECBUCaBx1cq/KcuFuY0GcubIgN2iNPdTLb2RM3/MQfuEvhg== X-Received: by 2002:a17:903:22d0:b0:1ff:49a0:46b1 with SMTP id d9443c01a7336-1ff49a05141mr11074115ad.6.1722443825004; Wed, 31 Jul 2024 09:37:05 -0700 (PDT) Received: from tp-fat-se.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff23ff5997sm60976385ad.267.2024.07.31.09.37.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2024 09:37:04 -0700 (PDT) From: Tathagat Priyadarshi To: rushilg@google.com, joshwash@google.com Cc: dev@dpdk.org, Tathagat Priyadarshi , Varun Lakkur Ambaji Rao Subject: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain Date: Wed, 31 Jul 2024 16:38:21 +0000 Message-Id: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The EOP bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur Ambaji Rao Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") --- drivers/net/gve/gve_tx_dqo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c index a65e6aa..579b8d6 100644 --- a/drivers/net/gve/gve_tx_dqo.c +++ b/drivers/net/gve/gve_tx_dqo.c @@ -126,6 +126,7 @@ txd->pkt.dtype = GVE_TX_PKT_DESC_DTYPE_DQO; txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id); txd->pkt.buf_size = RTE_MIN(tx_pkt->data_len, GVE_TX_MAX_BUF_SIZE_DQO); + txd->pkt.end_of_packet = 0; /* size of desc_ring and sw_ring could be different */ tx_id = (tx_id + 1) & mask; -- 1.8.3.1