From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by dpdk.org (Postfix) with ESMTP id 9C23C58E1 for ; Tue, 13 Sep 2016 15:38:25 +0200 (CEST) Received: by mail-lf0-f45.google.com with SMTP id h127so110209193lfh.0 for ; Tue, 13 Sep 2016 06:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=sJ5PRphA88R75RNR9NQ5ynKjfswAnA3DjqtGXPb4dkg=; b=v3yTx8uNysO5Dy3hNu3kZP7D6dbrTQeYtiJ9iWd07EP6AvFNhc/dp03Kr/HBnIeltx fpSXT3HCvnOSBx5TMCovirOSN51ERG/wYEJYED5MMje9mpYWhtUrk5CYeD4A45m0pDSP 0GQtG0/AyCU9cegj8VyLUkb/DSUnaCzb3nS3xJvml6UKUT92BdcwA66AjZJaxOLlsMxQ biRnXE06PPeajc2/udELXtOVh3qrkYT3RZR8WHSeWqaJRsB9L+aXB86imU5MFlsEdU24 2FdZ0pUaOsgqYriC1hOSrUvAJLRiM6MDGLPkmtHNq/qUhkYrsltxl8jN29kOwBKvigP+ tHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=sJ5PRphA88R75RNR9NQ5ynKjfswAnA3DjqtGXPb4dkg=; b=lr/K4zkhJq2xrC7zMuR/AxKCS4d41GiNcknXyTmOCAjd9B0MSQVOuayMqhx7FU3HZC pr1C4ZSqB3Ba6CjQhzTt4Xs9VT3PjL4aI8dUiFwxVpKMyRMfeWhHqSeLAq+2ANRom9K/ K+0ZQ5Lmf+T1nQtdlu6X+u+iG84BzAKKTWPl1owJ7QgWTkHbA5CShVZnszIVUfcl/XoX BeGpQ11u9UzCyPaXXrlhz7odRo/a9PfIulgKTwMhR/mMf6weU+6WIC04i3X2T9g6I62j /UKmvZFDrhXvdQDPwDfH5XRniBz4DgFQnarsNJIQfTDDnJs3GtgrMOAu2KENeEUKjGJ4 5LEQ== X-Gm-Message-State: AE9vXwPHBdELHxX9h2nf38crpKpD58ybA7A+DKj3A3WfzYGKRTcQijy4LiK3stJ+pZSF8ipD X-Received: by 10.194.201.230 with SMTP id kd6mr19394022wjc.167.1473773905179; Tue, 13 Sep 2016 06:38:25 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id t5sm22934980wjm.12.2016.09.13.06.38.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2016 06:38:24 -0700 (PDT) From: Thomas Monjalon To: Adrien Mazarguil Cc: dev@dpdk.org Date: Tue, 13 Sep 2016 15:38:23 +0200 Message-ID: <1722446.qpBii1xjhf@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 00/10] Fix build errors related to exported headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2016 13:38:25 -0000 2016-09-08 14:25, Adrien Mazarguil: > DPDK uses GNU C language extensions in most of its code base. This is fine > for internal source files whose compilation flags are controlled by DPDK, > however user applications that use exported "public" headers may experience > compilation failures when enabling strict error/standard checks (-std and > -pedantic for instance). > > Exported headers are installed system-wide and must be as clean as possible > so applications do not have to resort to workarounds. > > This patchset affects exported headers only, compilation problems are > addressed as follows: > > - Adding the __extension__ keyword to nonstandard constructs (same method > as existing libraries when there is no other choice). > - Adding the __extension__ keyword to C11 constructs to remain compatible > with pure C99. > - Adding missing includes so exported files can be included out of order > and on their own. > - Fixing GNU printf-like variadic macros as there is no magic keyword for > these. Applied, thanks The script is a bit slow so it is not integrated in test-build.sh yet. But it should allow us to take care of our exported headers in the future. Adrien, you'll be welcome to remind us how to keep things standard :)