Re: [dpdk-dev] [PATCH v4 0/7] Move EAL common function

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Ravi,

2015-01-06 12:24, Ravi Kerur:
> Fix v3 PATCH review comments from Thomas.
> eal_common.c is further split into eal_common_system.c and
> eal_common_runtime.c files with appropriate functions.
> eal_externs.h file is removed and _get_ and _set_ APIs are
> used to access variables.
> Functions with same signature in Linux and BSD but different
> names are kept intact but Linux function name is used as
> wrapper for BSD.
> Added eal_pci.c in v4 PATCH.
> New files added follow _common_ naming conventions.
> Tested against Ubuntu and FreeBSD.
> 
> Ravi Kerur (7):
>   Move common functions in eal_debug.c
>   Move common functions in eal_thread.c
>   Move common functions in eal.c
>   Move common functions in eal_lcore.c
>   Move common functions in eal_timer.c
>   Move common functions in eal_memory.c
>   Move common functions in eal_pci.c

Sorry for not integrating this big refactoring in release 2.0.
It wasn't easy to merge it during development of some EAL features.
And it's now too risky to rework it before the release.
I think this clean-up is needed and should be done at the beginning of 2.1
cycle. We just need to rebase it and remove the "ifdef BSD/LINUX" which was
introduced in pci code.

Do you think you'll have time for it?

Thanks