From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0076.outbound.protection.outlook.com [104.47.1.76]) by dpdk.org (Postfix) with ESMTP id 6D2EF4F91; Tue, 8 May 2018 21:19:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fV8HRdA6BTOD5ADTTEK9GnhqoQrEz1eXFlJ2b5eJPFU=; b=AXPLcjiUo6oaMqgRY8ZXezS7v0GTCfrp7vP2Rdx1kgur9UbvftciCCu4JmLpCxXVeSul8IYxwfFUBR/0AEUEtsuW/7AK4h6g8hoysvdAL06p+2zqti5Jfzl0v8/0wx9+XBjCoqJNkOMu3sAscWjLfCAiNhI/KrSb8tIVx0C8nqk= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2317.eurprd05.prod.outlook.com (10.169.135.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Tue, 8 May 2018 19:19:47 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0735.019; Tue, 8 May 2018 19:19:47 +0000 From: Yongseok Koh To: Raslan Darawsheh CC: Shahaf Shuler , "dev@dpdk.org" , Thomas Monjalon , Ophir Munk , "stable@dpdk.org" Thread-Topic: [PATCH v3 2/2] net/mlx5: fix resource leak in case of error Thread-Index: AQHT5qyWVOnYLD+VIEq39LM56xkKvaQmNbMA Date: Tue, 8 May 2018 19:19:47 +0000 Message-ID: <1722AD8A-15A4-4D8B-992D-1CCB84EFB1AD@mellanox.com> References: <1525770687-22980-1-git-send-email-rasland@mellanox.com> <1525770687-22980-2-git-send-email-rasland@mellanox.com> In-Reply-To: <1525770687-22980-2-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2317; 7:SKJBaApyWs7V56mazpn07qw67aS3gDTpCJyi0rHqa0406Jbhfvp3tY/6m2V0FCV0YBdUVf68we23S0Eti3t56ePCtxc32QJSye0ONWCdS0N8gPuHMMsfulhGhFXsBEOFp2sAdjA3d3aPeNj5NITtp/EoqHN9wqxKkGv1H27TBST87gKgTzIDG+DIugHFmYuT4bn1TTw8cuwce3lLH0WdrTeerlg9aioUl4h2XtjYlGfWv7aqYr5QNcfd32XEdj+Y x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2317; x-ms-traffictypediagnostic: VI1PR0501MB2317: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:VI1PR0501MB2317; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2317; x-forefront-prvs: 0666E15D35 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(366004)(376002)(39860400002)(396003)(199004)(189003)(5660300001)(106356001)(53936002)(6862004)(105586002)(2906002)(97736004)(6246003)(33656002)(6512007)(4326008)(6436002)(66066001)(5250100002)(6636002)(82746002)(36756003)(2900100001)(6486002)(11346002)(54906003)(76176011)(3846002)(446003)(25786009)(102836004)(6116002)(2616005)(99286004)(68736007)(83716003)(8676002)(7736002)(316002)(81156014)(37006003)(86362001)(53546011)(8936002)(6506007)(305945005)(486006)(26005)(81166006)(3280700002)(478600001)(476003)(3660700001)(14454004)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2317; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: bCn/2fEXmXnmr1rW0UIkXurlSf3sfac88b7gQutIGH1bXkRJ4g4SsKphOJS+H805oOw1cb1dtpNndXdhBAc94k5BwydcPiDiCiVpM50QZ6DLlKrDWPPbMltm+r3M2s2EcNon9XAYiXh0ndU13YBgcBxzKiFcCBQAqvekoYOo/VW3uUGrr4IxyRVCTXddKxA9 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 24a61beb-5ed9-43ec-1d05-08d5b518a9d5 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24a61beb-5ed9-43ec-1d05-08d5b518a9d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2018 19:19:47.4233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2317 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 19:19:50 -0000 > On May 8, 2018, at 2:11 AM, Raslan Darawsheh wrote= : >=20 > If something went wrong in mlx5 pci prop the allocated eth dev > will cause a memory leak. >=20 > This commit release the eth dev that was previously allocated. >=20 > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 = adapters") > Cc: stable@dpdk.org >=20 > Signed-off-by: Raslan Darawsheh >=20 > --- Acked-by: Yongseok Koh =20 Thanks