DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Doherty, Declan" <declan.doherty@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing
Date: Sun, 26 Jun 2016 18:31:57 +0200	[thread overview]
Message-ID: <1724516.iAvns5DDEp@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C96A09B@IRSMSX108.ger.corp.intel.com>

2016-06-25 15:24, De Lara Guarch, Pablo:
> > +DPDK_16.07 {
> > +	global:
> > +
> > +	rte_cryptodev_parse_vdev_init_params;
> 
> I think this function does not need to be public.
> This function is only called in the PMDs, and the only public function
> to initialize a crypto device is rte_eal_vdev_init.

It needs to be public to be called by the PMDs,
like, example, rte_cryptodev_pmd_virtual_dev_init.

> Also, could you remove the includes of rte_vargs.h in the PMDs,
> as it is not needed (I think it was not necessary before either).

Yes I am going to send a v3 with this change.
Thanks

  reply	other threads:[~2016-06-26 16:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 15:47 [dpdk-dev] [PATCH] " Thomas Monjalon
2016-06-25 13:13 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2016-06-25 15:24   ` De Lara Guarch, Pablo
2016-06-26 16:31     ` Thomas Monjalon [this message]
2016-06-26 16:33   ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2016-06-27 10:20     ` De Lara Guarch, Pablo
2016-06-27 15:06       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1724516.iAvns5DDEp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).