From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 080B65ABB for ; Sun, 26 Jun 2016 18:32:00 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id v199so73419311wmv.0 for ; Sun, 26 Jun 2016 09:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=nlvG93bztNWFjORkOv33dSUuGJwXvLYhipQIauCDx5g=; b=hcb3k/3pxDYK5e5PgPHOC9/9c6vw1NF1E003fXNTPToHompE6y6DnGQ4EfTs8/Rq2N AmKzEbFnsH3eWLX0XhgaSrXLR6SlJN49cnvE0pGTp/tXlpbyxKwPVKmIsDTHUrN0kip/ 2DayAed//mlpdBM71K0MZfuONOc/J2GiVsfxUM7keqUGI0e98aFajjyhIG0ZP68F3+un TWBDjqYcfhkBK3Tx7FsczMlCSGHNuuaZWqJ5jt1+L+Z3LTlVxhOsd1hBCeFF5vp7zazk fsCWA5QIOS+bQ8R/pHSE0LxIqiEW2hoVe3iZ4ubey4sLpOlj4NO3xsX8XW4mGkEZtGZY GCtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=nlvG93bztNWFjORkOv33dSUuGJwXvLYhipQIauCDx5g=; b=MC8s1Ea7n33UiJEjytq07uSx47sFc97jTl7bSPcoH3k3k6Hl71Dg8y92v691KTyN0l OamtmQjYxnXqY7vGs2I+O0RjOP0PWtIgeJXSSHvcuVLIXBvzK7FTIxnrU0CyjWZOAEOX CBPdFHD7RGUrd9fxI9i/MN3oHL/zClN0HtuDsU7k7TtCGBy+MrJGTtdJJehXY85uvp2Q 6wkNDh4BTOLCVIpA/AWa7QD0rFl9eif8TvUd+mHgXLW63fmk+Ozkm1TmiXGOr5dMbw2I KnyatiB3wPDMgtmInnxGV9+D/kc7dW9Rp8Occ29xA0zDj97bFdUzXRioVvgKUWyHOVD0 iQWw== X-Gm-Message-State: ALyK8tLa7fcTPrLCVbINEW7TJwoB71Z0taKKFzRWOLU5zkkLTQgQRF+S27sLrKOnHE+ztZcG X-Received: by 10.194.162.168 with SMTP id yb8mr13595964wjb.32.1466958719824; Sun, 26 Jun 2016 09:31:59 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b77sm1442453wme.0.2016.06.26.09.31.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jun 2016 09:31:58 -0700 (PDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Cc: "Doherty, Declan" , dev@dpdk.org Date: Sun, 26 Jun 2016 18:31:57 +0200 Message-ID: <1724516.iAvns5DDEp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1466783244-4484-1-git-send-email-thomas.monjalon@6wind.com> <1466860424-4155-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: uninline parameter parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2016 16:32:00 -0000 2016-06-25 15:24, De Lara Guarch, Pablo: > > +DPDK_16.07 { > > + global: > > + > > + rte_cryptodev_parse_vdev_init_params; > > I think this function does not need to be public. > This function is only called in the PMDs, and the only public function > to initialize a crypto device is rte_eal_vdev_init. It needs to be public to be called by the PMDs, like, example, rte_cryptodev_pmd_virtual_dev_init. > Also, could you remove the includes of rte_vargs.h in the PMDs, > as it is not needed (I think it was not necessary before either). Yes I am going to send a v3 with this change. Thanks