From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0ABBF2B92 for ; Wed, 25 Apr 2018 04:36:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5CC9620DD5; Tue, 24 Apr 2018 22:36:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 Apr 2018 22:36:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ah8mMGoBTIBLH4Jd6KFRL/uYTQ uvAuVs2B+KRyuivZM=; b=sQ2oLQ5HJ3TnluXyw8OQOkv/g4rABJ8tnwqxf/IF0/ 8CblIQx1+2MyHQFmpTX/GkNGkjuT7cvU1GxeXiJUqNO5e+f9KnF8ZKgbAt1FaDpy 4J/NHIuzYGmN8m79eTK5AF56R25CBdAstKLc/RmDPE27HoCnoBJeAUefwbUFCNwM s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ah8mMG oBTIBLH4Jd6KFRL/uYTQuvAuVs2B+KRyuivZM=; b=NsNA3/WbQyyoOOAFPGaHnU mDpKzLpHZ9RMzJbo5yftbeYpYEmL6qPcIVPluq0Eeg46z18/yywb0kR1GsnTUIiV M8mQX5KQ4L08l+YDC9tc7/Qf92zD0+vC0zmiE9+BVbfTMUSs5tsjQyWAAURkxGXT 6Glump08MPr7jcAskgm6A1hGIDcwvTuxrCBmVSAlXNQbavilY/q9ViSUWDTXmSwk 0sH13Djk1nTltypxLF5A3vcVHUZoTmm3ABXJpb2BJuxcT4a1lSF8wF/vfAHarxuE HKSvmgXpJPKEV3TWlsdppy3o0Q9nMvVXY3ATL8C6s64hY7fgVfVHYpOcQ7a0fQbg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37BF8E4488; Tue, 24 Apr 2018 22:36:17 -0400 (EDT) From: Thomas Monjalon To: Aaron Conole , Timothy Redaelli Cc: dev@dpdk.org, Bruce Richardson , Jan Viktorin , Jianbo Liu , Jerin Jacob , Chao Zhu , Keith Wiles Date: Wed, 25 Apr 2018 04:36:16 +0200 Message-ID: <1725964.sTXFLTeudM@xps> In-Reply-To: <22739292.VNXgVMcpcx@xps> References: <20180322153549.17910-1-aconole@redhat.com> <20180402182434.14045-1-aconole@redhat.com> <22739292.VNXgVMcpcx@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: abstract away the auxiliary vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 02:36:19 -0000 11/04/2018 23:34, Thomas Monjalon: > Anyone to review, please? > > 02/04/2018 20:24, Aaron Conole: > > Rather than attempting to load the contents of the auxv directly, > > prefer to use an exposed API - and if that doesn't exist then attempt > > to load the vector. This is because on some systems, when a user > > is downgraded, the /proc/self/auxv file retains the old ownership > > and permissions. The original method of /proc/self/auxv is retained. > > > > This also removes a potential abort() in the code when compiled with > > NDEBUG. A quick parse of the code shows that many (if not all) of > > the CPU flag parsing isn't used internally, so it should be okay. > > > > Signed-off-by: Aaron Conole > > Signed-off-by: Timothy Redaelli 3 weeks without a single comment. Applied with below fix, thanks fix applied: -#if RTE_ARCH_64 +#ifdef RTE_ARCH_64