From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 8B15347CE for ; Tue, 15 Mar 2016 00:20:49 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so3574329wml.1 for ; Mon, 14 Mar 2016 16:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=XnenGfbRePRgZXlL8beByYIJYv661RcaPPfyn/Jqa30=; b=rGVMrmlbGhoNPxeJZMKb+z/t5w1YXTJRwY2G3SgDB4vrCeOAgpOlFQ6iNIh7JUOx/x A++li6eJKfX6uMhHM8ehJgWQCuOw7EsxasOfwZKGwYftNFzhUKFlGMN7jdD8m9/Q3wYG XN84OYot+3xVIEIvo3detK2V04CN2GFh8G11paVtkGcSlQ6eFUsWWgl5MaFNrYm3+BB+ 1O08JsyCls5dVAQ2y4RFM8v7AKLGwizbS6MkdWG+kq21qvYRITvvaTJun7U2ozOahCPh J5l/3zYoxct8u8M79FIBia8N47ZP3g3IFC7C2tjOSVXugIBusJyaWVzrn1rsEuppZN1V /pyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=XnenGfbRePRgZXlL8beByYIJYv661RcaPPfyn/Jqa30=; b=mFKS7ml71PED7vefg7PpUQRbxisb7hhPnOv9g3NPgySTbV+mNcW7CT0dm+NcvfjNYw OLwa6jYcnxHBuP3o74anXiiMBJ6obDj+8/KvLW2QQtJudL6D0dJOhEBxh2UH5YPlETwP Q/R4iqrI0GLvmCcQ5vP44wte7kaJ9DSW5DzFkQ+swHjjth2TpfF8kYZMhvMfScAKQBB1 BA6B8Wg/WPDnZDdXuB6tDZzmCoMJbSUrRMSKNJjZhtXLBoVkc1DFQ/JkcCaLc24KOVwe opOnt76WMhLGKCV4d4MefMoZLOykVcVbyIniR7U4rVCMDH+Xs+KTAxYalCvj5qniObmQ 0VqA== X-Gm-Message-State: AD7BkJJUwcvUkpCQV/2kHqz5q0dPKO1ipejvibIZsZfvZxmASiyqKTyX8/9o8/GM+PML7B/F X-Received: by 10.28.223.70 with SMTP id w67mr19454081wmg.92.1457997649413; Mon, 14 Mar 2016 16:20:49 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id hx10sm24340762wjb.25.2016.03.14.16.20.48 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Mar 2016 16:20:48 -0700 (PDT) From: Thomas Monjalon To: Tetsuya Mukawa Cc: dev@dpdk.org, Yuanhan Liu , jianfeng.tan@intel.com, huawei.xie@intel.com Date: Tue, 15 Mar 2016 00:19:25 +0100 Message-ID: <1728165.aRGmEK0DRC@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160314091259.GN979@yliu-dev.sh.intel.com> References: <1457593565-16240-1-git-send-email-mukawa@igel.co.jp> <1457945612-30165-1-git-send-email-mukawa@igel.co.jp> <20160314091259.GN979@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] vhost: Fix default value of kickfd and callfd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 23:20:49 -0000 2016-03-14 17:12, Yuanhan Liu: > On Mon, Mar 14, 2016 at 05:53:32PM +0900, Tetsuya Mukawa wrote: > > Currently, default values of kickfd and callfd are -1. > > If the values are -1, current code guesses kickfd and callfd haven't > > been initialized yet. Then vhost library will guess the virtqueue isn't > > ready for processing. > > But callfd and kickfd will be set as -1 when "--enable-kvm" > > isn't specified in QEMU command line. It means we cannot treat -1 as > > uninitialized state. > > The patch defines -1 and -2 as VIRTIO_INVALID_EVENTFD and > > VIRTIO_UNINITIALIZED_EVENTFD, and uses VIRTIO_UNINITIALIZED_EVENTFD for > > the default values of kickfd and callfd. > > Don't be mean to put an empty line between paragraphs :) > > > Signed-off-by: Tetsuya Mukawa > > Acked-by: Yuanhan Liu Applied, thanks