From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Marvin Liu <yong.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build with libvirt version < 0.9.3
Date: Mon, 11 Apr 2016 11:26:59 +0200 [thread overview]
Message-ID: <1729179.ZFCP7VmEgh@xps13> (raw)
In-Reply-To: <1460364631-28381-1-git-send-email-yong.liu@intel.com>
2016-04-11 16:50, Marvin Liu:
> Fixes: 2e099bc5d104 ("fix split of compiler and linker options")
As commented earlier, I don't think it is the origin of the issue.
> +$(info "vm_power_manager required libvirt version >= 0.9.3, please update libvirt-devel first")
"required" should be "requires".
libvirt-devel is the name of the package on some distributions, but
it is not always the case. Moreover, the whole libvirt package must be
updated atomically, not only the headers. That's why I think it's better
to remove this part and just keep:
"vm_power_manager requires libvirt version >= 0.9.3"
Other issue: it would better to use $(error to generate a compilation error.
But the example should not be skipped from examples/Makefile in this case.
next prev parent reply other threads:[~2016-04-11 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 3:45 [dpdk-dev] [PATCH] " Marvin Liu
2016-04-11 7:24 ` Thomas Monjalon
2016-04-11 8:48 ` Liu, Yong
2016-04-11 8:50 ` [dpdk-dev] [PATCH v2] " Marvin Liu
2016-04-11 9:26 ` Thomas Monjalon [this message]
2016-04-11 9:32 ` Thomas Monjalon
2016-04-11 9:46 ` Liu, Yong
2016-04-11 10:06 ` [dpdk-dev] [PATCH v3] " Marvin Liu
2016-04-11 10:32 ` [dpdk-dev] [PATCH v4] examples/vm_power_manager: fix libvirt dependency check Thomas Monjalon
2016-04-11 10:37 ` Bruce Richardson
2016-04-11 10:43 ` [dpdk-dev] [PATCH v5] " Thomas Monjalon
2016-04-11 12:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1729179.ZFCP7VmEgh@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).