From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 8BBFF37A8 for ; Mon, 11 Apr 2016 11:27:01 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id f198so137134118wme.0 for ; Mon, 11 Apr 2016 02:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qPcx4AuuQAZW0oEDQRTOcZLy3RoRWF/dQRrq5flB+Ak=; b=oMSdzyi3r2fsuqDUNlb1IZaQ2BWpoSLGfgajLREepQwYZFZoR6rWR13gClZ2m9eP6x EIMTaF3NrsCoKUpzXxoauk3aDg0QJm+jDWfPU78ySlWKYysjpqLWnO14UP12TbdrqEIp xDIGm1aCs4/EDXQDCOkPencJWw4USlvp4mE8Dei5Go9gukSZJpGCpz+3jsgrcQ3yxNYf SZfCIBq+4h8OALX1RSCexM4wPKVrnof5IyaWct2OUcBBATgaTJBb/fkQNEzkCtgQfDDJ DZ8sD6tqn/vj13dU2myzj78hZizbg22h8lszufI065O0PNJx/4llwyXYB/vJOzPx//Sb rZGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=qPcx4AuuQAZW0oEDQRTOcZLy3RoRWF/dQRrq5flB+Ak=; b=fAX28ZySiqQxTEyQfZH4KlU2ig9u7MgTskksbwAct3fxAwW/PFBNqOZr8GJ4pqHpfF qwGZb+x+HCoSrINYX2qRk8gGdVa1hWjJoIJyT5nKCFNgIPbvIcIQX8iltEgL8oTIPcAF EkeAjWeMrugDJEUpaAdiQtN0bNpPo+8zfClM6JQ15vVXIX7ABTF0flDUm1nmiVRVlIRr KcAH681vfUj+OKp8n/zpxhp/1T6gplF+SLZCqVkS4sYDD6C+XyXDP9wvqPJWKeV57OBM R39EdJ9uy/b+BzTG7mXjt2Gp5i5hFdevwGlWGxkb5RuLU8xY0MS0sXcrUc7gTPy4QJww hC5A== X-Gm-Message-State: AD7BkJKoe5eUYus8IckmVxT3x7stAqS07Df91OpJB4FjVsySJIVTV/eGVYRlawvRW6B1Pc2r X-Received: by 10.28.125.2 with SMTP id y2mr17597715wmc.90.1460366821368; Mon, 11 Apr 2016 02:27:01 -0700 (PDT) Received: from xps13.localnet (245.111.75.86.rev.sfr.net. [86.75.111.245]) by smtp.gmail.com with ESMTPSA id i11sm26784966wjn.36.2016.04.11.02.27.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Apr 2016 02:27:00 -0700 (PDT) From: Thomas Monjalon To: Marvin Liu Cc: dev@dpdk.org Date: Mon, 11 Apr 2016 11:26:59 +0200 Message-ID: <1729179.ZFCP7VmEgh@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1460364631-28381-1-git-send-email-yong.liu@intel.com> References: <1460346357-26592-1-git-send-email-yong.liu@intel.com> <1460364631-28381-1-git-send-email-yong.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/vm_power_manager: fix build with libvirt version < 0.9.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 09:27:01 -0000 2016-04-11 16:50, Marvin Liu: > Fixes: 2e099bc5d104 ("fix split of compiler and linker options") As commented earlier, I don't think it is the origin of the issue. > +$(info "vm_power_manager required libvirt version >= 0.9.3, please update libvirt-devel first") "required" should be "requires". libvirt-devel is the name of the package on some distributions, but it is not always the case. Moreover, the whole libvirt package must be updated atomically, not only the headers. That's why I think it's better to remove this part and just keep: "vm_power_manager requires libvirt version >= 0.9.3" Other issue: it would better to use $(error to generate a compilation error. But the example should not be skipped from examples/Makefile in this case.