From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD031A04FD; Thu, 10 Nov 2022 11:26:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49FA940150; Thu, 10 Nov 2022 11:26:07 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id A6222400EF for ; Thu, 10 Nov 2022 11:26:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 1971E3200981; Thu, 10 Nov 2022 05:26:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 10 Nov 2022 05:26:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1668075963; x= 1668162363; bh=Hw5iKNgJm2+dbix9SvTbyLa1nZC4uCZIRLUg9wTgymQ=; b=o 24rDsIWhyCebxtXTlu/vcNaGtY7pDxbQTHD2ciSl0gmvGbWpi3XzAYuwJtsv0J6s qvteo9u6oaxMSQnl5m+bkyiv2DofJq+sDz50ru+zVabr9gPGhROXroL/42S0Fzrv CJDGldrsZagOfFelVhSCGVDJrA199xtICam0nXRSV9M3QNVkoT5o1rm9S1sTrPAg KaiAIzkpw9mK/89KTnca0l5Oy6Twx420RbVhFCc69J0fP0B6SpNO7e5Bx+xaEPPZ wY9i8ILHL0aexJYjNQYGTmtGxSPNK1hoGFB9P4tLyFDTz2VopO2MI+q5djXhbj/X /nH2l1+SNqb9lzod4ZIfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668075963; x= 1668162363; bh=Hw5iKNgJm2+dbix9SvTbyLa1nZC4uCZIRLUg9wTgymQ=; b=F 53IgDqzoOo/jkTFwsAdYkTLY7X/fUyuJ78xSU+cTDd5Al0qh3cqo8LlixUwb60oh 2wrZ63v5+nCt4TmuO+Rwzutrr9TUbLwNIkfVF8/wD2XH//QbHoT+zCjNfio2EEnQ ihbZp8aPkPt2TKqQq58P01TeTzFCvrLq+81rvHSc0fGDFfX5GSKfDpbz8wrPb/4w V5rq6pSI157ik0ruy831h4MGfEBI3cJbwMG3Qn9jQrMo3FR5ZVxfxiT6/5fqQY8n /gQPWO0+JMF8XyjhQq6qBoFoeZ19+Nt6JDSCPCvwRdJZKXHqssviC8OmX1srIkij Las0PxOe7lF0xghXeXzKg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfeeggdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Nov 2022 05:26:02 -0500 (EST) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "dev@dpdk.org" , Lijuan Tu , Owen Hilyard Subject: Re: [PATCH] devtools: set DTS directory to format check Date: Thu, 10 Nov 2022 11:26:00 +0100 Message-ID: <1729999.A0I09U8b9p@thomas> In-Reply-To: <464c6b5616664baa90655f6236fde2b2@pantheon.tech> References: <20221109170921.625192-1-thomas@monjalon.net> <464c6b5616664baa90655f6236fde2b2@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/11/2022 10:27, Juraj Linke=C5=A1: > From: Thomas Monjalon > > usage() { > > - echo "Run formatting and linting programs for DTS. Usage:" > > - > > + echo 'Usage: $(basename $0) [options] [directory]' >=20 > Double quotes here, otherwise $0 won't be expanded. I wonder how I tested it :) > > +directory=3D${1:-$(dirname $0)/../dts} > > +cd $directory || exit 1 >=20 > I'd like to include the information of where we're doing the fomatting in= the console output, e.g.: > echo "Formatting in $(pwd):" >=20 > We're silently chaning the directory, so this would be useful when runnin= g with no argument and the script doesn't change anything - as a confirmati= on that it ran over the files we wanted to. Good comment, I'll improve in v2. > Other than that, > Reviewed-by: Juraj Linke=C5=A1 > Tested-by: Juraj Linke=C5=A1 No it does not work, so you should not add your Tested-by. And in general, Reviewed-by is enough. And really, give your reviewed-by only when it's perfect :)