From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 555A143155; Fri, 13 Oct 2023 15:17:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3693F402DC; Fri, 13 Oct 2023 15:17:37 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 67CF74027D for ; Fri, 13 Oct 2023 15:17:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5DC295C0369; Fri, 13 Oct 2023 09:17:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 13 Oct 2023 09:17:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697203053; x=1697289453; bh=KL734wvfZCbBP5psqfH+RaAOA1cdPWTFXQH 7cg+XFhA=; b=txwdWnBJD8O7lqI7iq3ma5XBJyS6/SU59LVK4ym8NoKgS9d82Xk IwHr+Yc3YXxmxuQzFXtFXnPuECmOtv8MTku2zeMOEbUI9c73zFGOOf7OfEYWgUFo tdTGbhm7bGAvNc6/A6wcV77iikUUcWN7UIyAYIC1uUqEih45F1FS6oQSiWWjwM/R qEYrQPP1rjX/0Vmn815bI8gXoH7uRjcKj5ciZAQL+pKQuOewmgK2fOjpf0D0ygn/ IMksh7Bn/CIXjjtC750S0Sc9KUXoffebB4sfm8hKO08cwftpSRvNywQ9v4w5McRW KSMvA053h6drxY0G2S1FefDU4zzWecpEFjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1697203053; x=1697289453; bh=KL734wvfZCbBP5psqfH+RaAOA1cdPWTFXQH 7cg+XFhA=; b=aYwMoVLJckoPo10WfJX9rkzBhxQNxLhIVi1nv5ibbwVeuAF0lfh 7nW8NIxKaAxZTVJp9D3UEO2zm/IQFOYDpZPRGUGBcbTMEiOF3MBczNGuMBCw/oSr OdS5SrVsL5LZcluBNpW+bnE7RZ0u19uKstlXXaHdDGsxoPpXUCw7BKpsmJVHSKG8 tWD82MGn7RU5jYH18ntbOU6DqHXIwCifAAQPacPl2g4oCYlGT7AJAAHHr54KfvmO AqTANJ6tIL8cBvVk3A58rEbLyCLS5BTYbi3MCzi/XO1DH1fe6hD+Qrkw4hlAxmWQ 7qU3u/mPdsnUw79nhnig56HZ88/Hb/OXlsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrieefgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Oct 2023 09:17:31 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: qiming.yang@intel.com, zhichaox.zeng@intel.com, dev@dpdk.org, orika@nvidia.com, david.marchand@redhat.com, john.mcnamara@intel.com Subject: Re: [PATCH v5 5/5] doc: add generic flow doc for ice PMD Date: Fri, 13 Oct 2023 15:17:29 +0200 Message-ID: <1730069.QkHrqEjB74@thomas> In-Reply-To: <20230926112931.4191107-6-qi.z.zhang@intel.com> References: <20230814202616.3346652-1-qi.z.zhang@intel.com> <20230926112931.4191107-1-qi.z.zhang@intel.com> <20230926112931.4191107-6-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/09/2023 13:29, Qi Zhang: > +Generic Flow Support > +~~~~~~~~~~~~~~~~~~~~ > + > +The ice PMD provides support for the Generic Flow API (RTE_FLOW), enabling > +users to offload various flow classification tasks to the E810 NIC. > +The E810 NIC's packet processing pipeline consists of the following stages: > + > +Switch: Supports exact match and limited wildcard matching with a large flow > +capacity. > + > +ACL: Supports wildcard matching with a smaller flow capacity (DCF mode only). > + > +FDIR: Supports exact match with a large flow capacity (PF mode only). > + > +Hash: Supports RSS (PF mode only) > + > +The ice PMD utilizes the ice_flow_engine structure to represent each of these > +stages and leverages the rte_flow rule's ``group`` attribute for selecting the > +appropriate engine for Switch, ACL, and FDIR operations: > + > +Group 0 maps to Switch > +Group 1 maps to ACL > +Group 2 maps to FDIR > + > +In the case of RSS, it will only be selected if a ``RTE_FLOW_ACTION_RSS`` action > +is targeted to no queue group, and the group attribute is ignored. > + > +For each engine, a list of supported patterns is maintained in a global array > +named ``ice__supported_pattern``. The Ice PMD will reject any rule with > +a pattern that is not included in the supported list. Why not choosing the right engine automatically? You are defining an API (group number specialization) which is specific to this driver. Don't you care about portability of DPDK applications?