DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: dev@dpdk.org
Cc: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: [PATCH v7 05/21] hash: remove use of VLAs for Windows built code
Date: Mon, 11 Nov 2024 18:01:57 -0800	[thread overview]
Message-ID: <1731376933-19275-6-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1731376933-19275-1-git-send-email-andremue@linux.microsoft.com>

From: Konstantin Ananyev <konstantin.ananyev@huawei.com>

1) ./lib/hash/rte_cuckoo_hash.c:2362:9
    : warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
    : warning: ISO C90 forbids variable length array ‘positions’

Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash_bulk_data() expect
@num_keys <= RTE_HASH_LOOKUP_BULK_MAX.
So, for both cases it should be safe to replace VLA with fixed size
array.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
---
 lib/hash/rte_cuckoo_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9575e8aa0c..fc93182efe 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -2418,7 +2418,7 @@ rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
 			(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
 			(hit_mask == NULL)), -EINVAL);
 
-	int32_t positions[num_keys];
+	int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
 	__rte_hash_lookup_bulk(h, keys, num_keys, positions, hit_mask, data);
 
@@ -2534,7 +2534,7 @@ rte_hash_lookup_with_hash_bulk_data(const struct rte_hash *h,
 			(num_keys > RTE_HASH_LOOKUP_BULK_MAX) ||
 			(hit_mask == NULL)), -EINVAL);
 
-	int32_t positions[num_keys];
+	int32_t positions[RTE_HASH_LOOKUP_BULK_MAX];
 
 	__rte_hash_lookup_with_hash_bulk(h, keys, sig, num_keys,
 			positions, hit_mask, data);
-- 
2.34.1


  parent reply	other threads:[~2024-11-12  2:02 UTC|newest]

Thread overview: 174+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 23:41 [PATCH 00/16] " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 01/16] eal: include header required for alloca Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 02/16] hash: remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-18  6:45   ` Morten Brørup
2024-04-17 23:41 ` [PATCH 03/16] ethdev: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 04/16] gro: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 05/16] latencystats: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 06/16] lpm: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 07/16] rcu: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 08/16] app/testpmd: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 09/16] test: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 10/16] common/idpf: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 11/16] net/i40e: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 12/16] net/ice: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 13/16] net/ixgbe: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 14/16] common/mlx5: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 15/16] net/mlx5: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 16/16] build: enable vla warnings on " Tyler Retzlaff
2024-04-18  6:48   ` Morten Brørup
2024-04-18 15:12     ` Tyler Retzlaff
2024-04-18 15:23       ` Bruce Richardson
2024-04-18 19:22         ` Morten Brørup
2024-04-18  6:49 ` [PATCH 00/16] remove use of VLAs for " Morten Brørup
2024-04-18 12:11 ` Konstantin Ananyev
2024-04-18 15:15   ` Tyler Retzlaff
2024-04-18 15:35     ` Konstantin Ananyev
2024-04-18 20:02 ` [PATCH v2 00/19] remove use of VLAs for Windows Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 01/19] eal: include header required for alloca Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 02/19] eal/linux: remove use of VLAs Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 03/19] eal/common: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 04/19] ethdev: remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 05/19] hash: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 06/19] hash/thash: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 07/19] rcu: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 08/19] gro: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 09/19] latencystats: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 10/19] lpm: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 11/19] app/testpmd: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 12/19] test: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 13/19] common/idpf: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 14/19] net/i40e: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 15/19] net/ice: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 16/19] net/ixgbe: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 17/19] common/mlx5: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 18/19] net/mlx5: " Tyler Retzlaff
2024-04-18 20:02   ` [PATCH v2 19/19] build: enable vla warnings on " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 00/19] remove use of VLAs for Windows Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 01/19] eal: include header required for alloca Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 02/19] eal/linux: remove use of VLAs Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 03/19] eal/common: " Tyler Retzlaff
2024-05-07  0:42     ` Stephen Hemminger
2024-05-06 18:18   ` [PATCH v3 04/19] ethdev: remove use of VLAs for Windows built code Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 05/19] hash: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 06/19] hash/thash: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 07/19] rcu: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 08/19] gro: " Tyler Retzlaff
2024-05-07  0:47     ` Stephen Hemminger
2024-05-06 18:18   ` [PATCH v3 09/19] latencystats: " Tyler Retzlaff
2024-05-07  0:47     ` Stephen Hemminger
2024-05-06 18:18   ` [PATCH v3 10/19] lpm: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 11/19] app/testpmd: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 12/19] test: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 13/19] common/idpf: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 14/19] net/i40e: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 15/19] net/ice: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 16/19] net/ixgbe: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 17/19] common/mlx5: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 18/19] net/mlx5: " Tyler Retzlaff
2024-05-06 18:18   ` [PATCH v3 19/19] build: enable vla warnings on " Tyler Retzlaff
2024-05-07  2:53   ` [PATCH 1/2] lpm: remove unnecessary temporary VLA Stephen Hemminger
2024-05-07  2:53     ` [PATCH 2/2] latencystats: replace use of VLA Stephen Hemminger
2024-07-09  8:06       ` David Marchand
2024-05-07  7:51     ` [PATCH 1/2] lpm: remove unnecessary temporary VLA Bruce Richardson
2024-07-09  8:26   ` [PATCH v3 00/19] remove use of VLAs for Windows David Marchand
2024-10-07 17:15 ` [PATCH 00/16] remove use of VLAs for Windows built code Stephen Hemminger
2024-11-01 18:06   ` Andre Muezerie
2024-11-05  3:15 ` [PATCH v4 00/19] remove use of VLAs for Windows Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 01/19] eal: include header required for alloca Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 02/19] eal/linux: remove use of VLAs Andre Muezerie
2024-11-05  8:19     ` David Marchand
2024-11-06  2:02       ` Andre Muezerie
2024-11-08 13:44         ` Konstantin Ananyev
2024-11-05  3:15   ` [PATCH v4 03/19] eal/common: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 04/19] ethdev: remove use of VLAs for Windows built code Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 05/19] hash: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 06/19] hash/thash: remove use of VLAs for Windows built Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 07/19] rcu: remove use of VLAs for Windows built code Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 08/19] gro: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 09/19] app/testpmd: remove use of VLAs for Windows built Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 10/19] test: remove use of VLAs for Windows built code Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 11/19] common/idpf: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 12/19] net/i40e: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 13/19] net/ice: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 14/19] net/ixgbe: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 15/19] common/mlx5: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 16/19] net/mlx5: " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 17/19] build: enable vla warnings on " Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 18/19] test: remove use of VLAs for Windows built code in bitset tests Andre Muezerie
2024-11-05  8:32     ` David Marchand
2024-11-06  2:06       ` Andre Muezerie
2024-11-05  3:15   ` [PATCH v4 19/19] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Andre Muezerie
2024-11-05  9:37   ` [PATCH v4 00/19] remove use of VLAs for Windows Konstantin Ananyev
2024-11-08  0:44 ` [PATCH v5 00/20] " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 01/20] eal: include header required for alloca Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 02/20] eal/linux: remove use of VLAs Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 03/20] eal/common: " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 04/20] ethdev: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 05/20] hash: " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 06/20] hash/thash: remove use of VLAs for Windows built Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 07/20] rcu: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 08/20] net/ice: " Andre Muezerie
2024-11-08  8:51     ` Bruce Richardson
2024-11-08 10:18       ` Konstantin Ananyev
2024-11-08 21:21         ` Andre Muezerie
2024-11-08 21:17       ` Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 09/20] gro: remove use of VLAs Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 10/20] net/ixgbe: " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 11/20] net/ice: " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 12/20] app/testpmd: remove use of VLAs for Windows built Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 13/20] test: remove use of VLAs for Windows built code Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 14/20] common/idpf: " Andre Muezerie
2024-11-08  8:47     ` Bruce Richardson
2024-11-08  0:44   ` [PATCH v5 15/20] net/i40e: " Andre Muezerie
2024-11-08  8:45     ` Bruce Richardson
2024-11-08  0:44   ` [PATCH v5 16/20] common/mlx5: " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 17/20] net/mlx5: " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 18/20] build: enable vla warnings on " Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 19/20] test: remove use of VLAs for Windows built code in bitset tests Andre Muezerie
2024-11-08  0:44   ` [PATCH v5 20/20] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Andre Muezerie
2024-11-09  1:47 ` [PATCH v6 00/20] remove use of VLAs for Windows Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 01/20] eal: include header required for alloca Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 02/20] eal/linux: remove use of VLAs Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 03/20] eal/common: " Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 04/20] ethdev: remove use of VLAs for Windows built code Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 05/20] hash: " Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 06/20] hash/thash: remove use of VLAs for Windows built Andre Muezerie
2024-11-09  1:47   ` [PATCH v6 07/20] rcu: remove use of VLAs for Windows built code Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 08/20] gro: fix overwrite unprocessed packets Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 09/20] gro: remove use of VLAs Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 10/20] net/ixgbe: " Andre Muezerie
2024-11-11  9:16     ` Burakov, Anatoly
2024-11-09  1:48   ` [PATCH v6 11/20] net/ice: " Andre Muezerie
2024-11-11  9:16     ` Burakov, Anatoly
2024-11-09  1:48   ` [PATCH v6 12/20] app/testpmd: remove use of VLAs for Windows built Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 13/20] test: remove use of VLAs for Windows built code Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 14/20] common/idpf: " Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 15/20] net/i40e: " Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 16/20] common/mlx5: " Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 17/20] net/mlx5: " Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 18/20] build: enable vla warnings on " Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 19/20] test: remove use of VLAs for Windows built code in bitset tests Andre Muezerie
2024-11-09  1:48   ` [PATCH v6 20/20] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Andre Muezerie
2024-11-12  2:01 ` [PATCH v7 00/21] remove use of VLAs for Windows Andre Muezerie
2024-11-12  2:01   ` [PATCH v7 01/21] eal: include header required for alloca Andre Muezerie
2024-11-12  2:01   ` [PATCH v7 02/21] eal/linux: remove use of VLAs Andre Muezerie
2024-11-12  2:01   ` [PATCH v7 03/21] eal/common: " Andre Muezerie
2024-11-12  2:01   ` [PATCH v7 04/21] ethdev: remove use of VLAs for Windows built code Andre Muezerie
2024-11-12  2:01   ` Andre Muezerie [this message]
2024-11-12  2:01   ` [PATCH v7 06/21] hash/thash: remove use of VLAs for Windows built Andre Muezerie
2024-11-12  2:01   ` [PATCH v7 07/21] rcu: remove use of VLAs for Windows built code Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 08/21] gro: fix overwrite unprocessed packets Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 09/21] gro: remove use of VLAs Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 10/21] net/ixgbe: " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 11/21] net/ice: " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 12/21] app/testpmd: remove use of VLAs for Windows built Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 13/21] test: remove use of VLAs for Windows built code Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 14/21] common/idpf: " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 15/21] net/i40e: " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 16/21] common/mlx5: " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 17/21] net/mlx5: " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 18/21] build: enable vla warnings on " Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 19/21] test: remove use of VLAs for Windows built code in bitset tests Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd Andre Muezerie
2024-11-12  2:02   ` [PATCH v7 21/21] hash: remove use of VLAs by using standard arrays Andre Muezerie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1731376933-19275-6-git-send-email-andremue@linux.microsoft.com \
    --to=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).