From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 436CB58D8 for ; Thu, 4 Feb 2016 10:22:21 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id l66so107678309wml.0 for ; Thu, 04 Feb 2016 01:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=cB5DToZVyfQmw51K2EutSv5FdwW8oSKIK7eeA2WRq3I=; b=EwCIhyPJYUfs0pLu070Rz9NrpkOHkFjcIo6opL7CF0KCYNhMv/y8lvcI+p0/1NUiO3 VVr/Epm/mT3H4BSPiuEgRRP9Nsf2pvFwtOQ0YM6sqk6HJUaW3lCCKaG7nKZAiu1msqJi Te9rL3GtX75yT+IpbJY/0HwmzgXc3f7khvyhNhnyVXCWsLAo6WA0jMtAfflPojv+bjz4 3mUbKCjJc9JPl7l8O219tR7HKli6eRinv0N2ZyXA25icIenQAVpLwbM19VWtpPr9xnKI Zo5WzDmryGDWV66vhI/M2fQ0V1VH8Itsph9Un6k6XH9Mk+pkxYSQA4UC3x9c3M+tJNQ+ NINg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=cB5DToZVyfQmw51K2EutSv5FdwW8oSKIK7eeA2WRq3I=; b=MmvJ2J42oZocwFZut2iGjcvJTf/tKsInG78xD1ot7TtTbv6byBVzX2DuaWcU7Bh58p VjXfJ73hjsFFgnVpbRRmKllqXpHL/ocDQdMnyGMBt5RYkJEY98UgPRqUB+Bq1UcrYYra Z+Kc84tqlMwzQOjq/qfxa1jd/ORUSqniLdPYWvFos8qiu1k3lIpjj03/9rL84EU0GKhg ujpSqzWdiJ5vsakzpWx9myWRdFLt/hVz3zau+MVv7ucrT5TmEAJGa3S7rBSwnq/DrRYw h+ImBGZ7iG6+EK7wCbhzAFul57qytedcQc4fMQjzCO7GLYZrBr8VRCfwCrU54WTmUSEo ZQrw== X-Gm-Message-State: AG10YOSolHZXFJrLPLaOvekuzcExy9IObrfXi/BM/cEJPP4IO+ebdmAZ2F8ZbWfJC76yCGhP X-Received: by 10.28.187.198 with SMTP id l189mr21624609wmf.0.1454577741156; Thu, 04 Feb 2016 01:22:21 -0800 (PST) Received: from xps13.localnet (136.21.90.92.rev.sfr.net. [92.90.21.136]) by smtp.gmail.com with ESMTPSA id c26sm25435175wmi.24.2016.02.04.01.22.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 04 Feb 2016 01:22:20 -0800 (PST) From: Thomas Monjalon To: "Wang, Zhihong" Date: Thu, 04 Feb 2016 10:21:07 +0100 Message-ID: <1731810.hWX6rzJA2p@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2848756.Pj2zKKyaol@xps13> References: <1454525799-25552-1-git-send-email-thomas.monjalon@6wind.com> <8F6C2BD409508844A0EFC19955BE0941033ACABA@SHSMSX103.ccr.corp.intel.com> <2848756.Pj2zKKyaol@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] eal/x86: fix build with clang for old AVX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 09:22:21 -0000 2016-02-04 09:47, Thomas Monjalon: > 2016-02-04 03:35, Wang, Zhihong: > > > Subject: [PATCH 1/3] eal/x86: fix build with clang for old AVX > > > > > > When configuring RTE_MACHINE to "default", rte_memcpy implementation > > > is the default one (old AVX). > > > In this code, clang raises a warning thanks to -Wsometimes-uninitialized: > > > > > > rte_memcpy.h:838:6: error: > > > variable 'srcofs' is used uninitialized whenever 'if' condition is false > > > if (dstofss > 0) { > > > ^~~~~~~~~~~ > > > rte_memcpy.h:849:6: note: uninitialized use occurs here > > > if (srcofs == 0) { > > > ^~~~~~ > > > > > > It is fixed by initializing srcofs to 0. > > > > > > Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512") > > > > Hi Thomas, > > > > Thanks for pointing this out! > > My last hasty modification on this is not correct. > > > > The patch below will fix it. All modifications are tested. > > Sorry for all the hassle! :'( > > > > "srcofs" should be calculated based on source address anyway. > > OK > Please send a full patch as usual, thanks. Sorry I've just caught you have already sent it. Thanks