From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id A64BF1B4DD for ; Wed, 11 Jul 2018 21:58:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 723B52B2; Wed, 11 Jul 2018 15:58:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 11 Jul 2018 15:58:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=n49QjbFY0hgFSfnOXCbfCMInFE 4nBBn7UuBX6/y3prg=; b=oxG2yacgtVWU5gTLNgaIg6vOrrZX1zAxPjQV8IytLw aWVy6LNEo5q7nfl2zVvRryKybN8dypJAeNnlZZc1WO5c9x+EV1Kp+6BMqlnyH7zZ OwnbRfS24dRpLjPpRrNjAbXiB953+4D1mw034rMsZejbKSPMVwUaVHVcEeg5Ot3r M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=n49Qjb FY0hgFSfnOXCbfCMInFE4nBBn7UuBX6/y3prg=; b=Eax85HxiP70m+JAJP+YoeY lFFhE2Qkfgh6QEyptH3wbxeWTEM+SG5NQpfxvr56vHdrNB2bJujwkgl/GVih1nZp ZXyIT9CTPfqOPBTDMGx88WMMyLM+Z7TpvKJfdVILQ1OkcKR8kFs6CFfl63ZqQpEM 2acgkl8tgpqLErTgbVqXNDAqd2XpfQGj5jNSLSaY9e+DonxoxhK8ROhA5q5oMuuM BQbRfdfnNVUqFQnbKfriY60lUjk6L//1POY9dI3kZgUTYZne5Sk9YexnAhfL0nzh H5EgXZsFCQN//vtgZTk7Tzxd5aEFWw+33YMBXSZ5iFc/9lbpBeNUfiV4t1Jix32Q == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4820F1025C; Wed, 11 Jul 2018 15:58:03 -0400 (EDT) From: Thomas Monjalon To: Jasvinder Singh Cc: dev@dpdk.org, cristian.dumitrescu@intel.com Date: Wed, 11 Jul 2018 21:58:02 +0200 Message-ID: <1732348.hrkfh3074m@xps> In-Reply-To: <20180705154754.147420-14-jasvinder.singh@intel.com> References: <20180627163123.135686-2-jasvinder.singh@intel.com> <20180705154754.147420-1-jasvinder.singh@intel.com> <20180705154754.147420-14-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 19:58:06 -0000 05/07/2018 17:47, Jasvinder Singh: > Add connection agent to enable connectivity with external agen > (e.g. telnet, netcat, Python script, etc). > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Jasvinder Singh > --- > config/common_base | 2 +- > config/common_linuxapp | 1 + > drivers/net/softnic/Makefile | 12 +- > drivers/net/softnic/conn.c | 332 +++++++++++++++++++++ > drivers/net/softnic/conn.h | 49 +++ > drivers/net/softnic/rte_eth_softnic.c | 79 ++++- > drivers/net/softnic/rte_eth_softnic.h | 16 + > drivers/net/softnic/rte_eth_softnic_internals.h | 3 + > ...nic_version.map => rte_eth_softnic_version.map} | 6 + > 9 files changed, 496 insertions(+), 4 deletions(-) > create mode 100644 drivers/net/softnic/conn.c > create mode 100644 drivers/net/softnic/conn.h > rename drivers/net/softnic/{rte_pmd_softnic_version.map => rte_eth_softnic_version.map} (52%) Why are you renaming this file? If you test the compilation with devtools/test-meson-builds.sh you will see this error: drivers/meson.build:111:3: ERROR: File drivers/net/softnic/rte_pmd_softnic_version.map does not exist. > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > +$(info Softnic PMD can only operate in a linuxapp environment, \ I think it is a really wrong idea to limit softnic to Linux only.