DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Ori Kam <orika@nvidia.com>,
	dev@dpdk.org, Gregory Etelson <getelson@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Dariusz Sosnowski <dsosnowski@nvidia.com>,
	Maayan Kashani <mkashani@nvidia.com>
Subject: Re: [PATCH] net/mlx5: enhance error log for tunnel offloading
Date: Wed, 24 May 2023 18:31:10 +0200	[thread overview]
Message-ID: <1732508.vCJZsxu672@thomas> (raw)
In-Reply-To: <CAJFAV8w6=u+LmOTThWXJ7kwASRf-QLCgO9BxnSBeYMHuQ_BfQA@mail.gmail.com>

27/04/2023 14:23, David Marchand:
> Hello guys,
> 
> On Thu, Apr 27, 2023 at 1:56 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Tunnel offloading is linked to running a port with the non-obvious
> > dv_xmeta_en=3 devargs. Hint at it for "normal" users.
> >
> > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> 
> Regardless of what happens to this patch, would it be possible to move
> away from those dv_xxx_en devargs things and go with a more
> straightforward API, like requesting tunnel offloading (or other) in
> rte_flow_configure?

Yes it is a good idea to use rte_flow_configure() for such configuration
of the ethernet port.
If we get application requirements dynamically,
then we can better allocate resources
and check for invalid combinations of features.



  reply	other threads:[~2023-05-24 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 11:55 David Marchand
2023-04-27 12:23 ` David Marchand
2023-05-24 16:31   ` Thomas Monjalon [this message]
2023-04-27 13:05 ` Gregory Etelson
2023-05-24  6:42 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1732508.vCJZsxu672@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=getelson@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=mkashani@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).