From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1775D42B8F; Wed, 24 May 2023 18:31:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A052E40156; Wed, 24 May 2023 18:31:14 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C5D6A400EF for ; Wed, 24 May 2023 18:31:13 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6B3575C01BF; Wed, 24 May 2023 12:31:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 24 May 2023 12:31:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1684945873; x=1685032273; bh=OasU7AkUP646SYw9c5mdTBCpBKU4JnsDPxy Wz7dx668=; b=wRdJ3cGf55R6HCbWeFOSYUyAv+4KTEMw/6ANLi9x3Vt2+5VdhTC i8AIc6Mp74OTWVSYByPNvPVB6TuA0bOqCtCKfmRfh81WcQ9pAWfyU3kYdsyOxtH1 LJNtDFe1wbshpPMZTaLdEP6pYYqhbaFV7UFGg6go8HPOQzY11BOFj4ZmQqv4AA0D Cfx2s4xodtOj/edbDrPEmvWf5DgvM+F6rJokV0qGv012f+V54k80wnOqmLT28I5e 8VbwuQPULO8rhxHJ2RZECAVyE5weItYzWce9FtLarYq0Jm428HFd6VUj/QwYMtBO s4N3uu4cUPeHZMPYBN08yxqIs1qscYyynGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684945873; x=1685032273; bh=OasU7AkUP646SYw9c5mdTBCpBKU4JnsDPxy Wz7dx668=; b=cKozX6YHh4rcCTMdY4QUKuQCBnawhX79u9RyVzPRpj99ZgbaH0U Eb23I0YwJAz/EXN7GcyjFffvGvG3xcmXmt73pv767Iz8fuPNDx+0qcMysAH65xRl m/Bpqi+ivoyWEwmPBrqpCbcehU0rI5ZugNVczSwhLzykMfhx9d1ir7DKlqsoU6U6 KllQvwkL2EnUuPIwf/wn7OuwkhzsSkA0cN5j22HWey3vasot+0LgMcbSIAl5ST4M NN92RfFrRNgNHKa9b9p9HwKardTI8OGUcyrfBen8BpFTxttbnp5eOoFO1meixsfB eajaUfSMNsVlkbL57+j4ptZm1BRoFtgIjSA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 May 2023 12:31:11 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , dev@dpdk.org, Gregory Etelson , Raslan Darawsheh , Dariusz Sosnowski , Maayan Kashani Subject: Re: [PATCH] net/mlx5: enhance error log for tunnel offloading Date: Wed, 24 May 2023 18:31:10 +0200 Message-ID: <1732508.vCJZsxu672@thomas> In-Reply-To: References: <20230427115534.1277154-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/04/2023 14:23, David Marchand: > Hello guys, >=20 > On Thu, Apr 27, 2023 at 1:56=E2=80=AFPM David Marchand > wrote: > > > > Tunnel offloading is linked to running a port with the non-obvious > > dv_xmeta_en=3D3 devargs. Hint at it for "normal" users. > > > > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") > > > > Signed-off-by: David Marchand >=20 > Regardless of what happens to this patch, would it be possible to move > away from those dv_xxx_en devargs things and go with a more > straightforward API, like requesting tunnel offloading (or other) in > rte_flow_configure? Yes it is a good idea to use rte_flow_configure() for such configuration of the ethernet port. If we get application requirements dynamically, then we can better allocate resources and check for invalid combinations of features.