From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF98645D31; Wed, 27 Nov 2024 01:55:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C2BB42D28; Wed, 27 Nov 2024 01:53:30 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 95CB7427CE for ; Wed, 27 Nov 2024 01:53:04 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 19B282050D86; Tue, 26 Nov 2024 16:53:02 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 19B282050D86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1732668784; bh=hX5Lvh+cQGArqOHZbfyHVs6/fVVGB/6S2bkGaZvwba4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FCF2TT/UlJyhBQZp86dmQdKM3KxjpfJhZ+yMJmv8AC9KhwXsakd4jA+E0WAPq+7/f JwFd5f1+F9SX57HCRYWeI6U/64zUTvqKu4JQN1LomSB3/RFT+YtDliTPtmwhMqICSD oInqIO9PpW3P1xeTc1YmImqIHUWgTI/ujr5WkmF0= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v6 29/30] lib/vhost: replace packed attributes Date: Tue, 26 Nov 2024 16:52:40 -0800 Message-Id: <1732668761-5556-30-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1732668761-5556-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1732668761-5556-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Signed-off-by: Andre Muezerie --- lib/vhost/vhost_user.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h index edf7adb3c0..d48542e72f 100644 --- a/lib/vhost/vhost_user.h +++ b/lib/vhost/vhost_user.h @@ -143,7 +143,7 @@ struct vhost_user_config { uint8_t region[VHOST_USER_MAX_CONFIG_SIZE]; }; -typedef struct VhostUserMsg { +typedef __rte_packed_begin struct VhostUserMsg { union { uint32_t frontend; /* a VhostUserRequest value */ uint32_t backend; /* a VhostUserBackendRequest value*/ @@ -169,16 +169,16 @@ typedef struct VhostUserMsg { struct vhost_user_config cfg; } payload; /* Nothing should be added after the payload */ -} __rte_packed VhostUserMsg; +} __rte_packed_end VhostUserMsg; /* Note: this structure and VhostUserMsg can't be changed carelessly as * external message handlers rely on them. */ -struct __rte_packed vhu_msg_context { +__rte_packed_begin struct vhu_msg_context { VhostUserMsg msg; int fds[VHOST_MEMORY_MAX_NREGIONS]; int fd_num; -}; +} __rte_packed_end; #define VHOST_USER_HDR_SIZE offsetof(VhostUserMsg, payload.u64) -- 2.34.1