From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2F9201F1C
 for <dev@dpdk.org>; Fri, 26 Oct 2018 21:59:42 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BCA982204C;
 Fri, 26 Oct 2018 15:59:41 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 26 Oct 2018 15:59:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=L25EGlvohbpgNuHpZaxlHOuVe7/Lfpc3IVwAxccBhbU=; b=Dmov2e38qgGL
 b4lDYmjHjdouewQk9M42EsU9VUTw9uS3HsFSogU+oApd7rnr4BY5iBnCA418ILyh
 4IqARDwqfewJSBACJAdY6Qcy6k8aQWqfGzXJ6Vbmni2StSAG+9+lArIIy7m9T+RB
 yO79YY+IbuL2dBjtHNGmxDOSQPk1OOw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=L25EGlvohbpgNuHpZaxlHOuVe7/Lfpc3IVwAxccBh
 bU=; b=GfQFnMwkIOj2eVauSE4X24P+AdsjmkVmnwHbyu7i5ZifjSCjz9EvCmZTW
 IRgP5fwsv7Qc2uTKk6AKiADhDZxuR8y4t7cggHAxpdle98EEswZf3bTvV4BAzF0S
 jleQWYmq7Jz88coQiUh6cbTiO+FaQQ3pykIHBI5Z4wIqQa4I/X459Gb4qPFMhItt
 keJtHnjr/jm8cCUR+g2JaNGOI8B2QWvwB9Cdr4QJnCy2xIHJv4lpQn/bIzLdvEXF
 7g1nj+4bm1yLCcAg16UrFZD7c2JyD2V/LunlqO0JcEBWVUUalBOnf+C4mGfGs4tl
 p01t0kRe9r9tZdjCP+V/p/rBqfSBA==
X-ME-Sender: <xms:LXLTWxSiozi_StGNHuyEOumbHy6T0fT__Yoez771FPp_dFqL42-cRg>
X-ME-Proxy: <xmx:LXLTW9T1RZIPR41aEj57WqEgx9I_p1FXHo7rsADSNLNx-HILeznisQ>
 <xmx:LXLTW0ts8MGMsA1vTwOB8g6gTOeDY5ZyGliM65QfarnsQ-948rvOGA>
 <xmx:LXLTW6b7k13eHuTnhwC6wXe6InSEf-I_BUUZWly40QjMnR562yJgnA>
 <xmx:LXLTWxs1uVpmhACc5B6-8w5AJLDeRJN65ztUiWfJXnbvCbiINjepEg>
 <xmx:LXLTW0GRCkG7puHy1LBITPCe8bgQPsGBJJOcaPlxr1qPc6jkHi1DvA>
 <xmx:LXLTW2RyCr0GJV7Y98NIixxYJ9pS6J4d8DMJaBSeKkVJ-MuhMSWFpA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C7359E421C;
 Fri, 26 Oct 2018 15:59:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Date: Fri, 26 Oct 2018 21:59:46 +0200
Message-ID: <1732780.omknZ3gl4j@xps>
In-Reply-To: <bea68a1b-e4f0-d6a9-8f68-ae3a09f982f8@intel.com>
References: <20181026184248.78908-1-ferruh.yigit@intel.com>
 <1826680.rqYCJSl033@xps> <bea68a1b-e4f0-d6a9-8f68-ae3a09f982f8@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] buildtools: fix build for some mktemp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2018 19:59:42 -0000

26/10/2018 20:31, Ferruh Yigit:
> On 10/26/2018 6:59 PM, Thomas Monjalon wrote:
> > 26/10/2018 20:42, Ferruh Yigit:
> >> build error:
> >> == Build drivers/net/tap
> >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> >> Invalid argument
> >> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
> >> .../drivers/net/tap/Makefile:55: recipe for target
> >>    'tap_autoconf.h.new' failed
> >>
> >> Above error observed on Wind River Linux 8.0
> >>
> >> `mktemp` command in that system has a restrictions to have X in
> >> the template at the end and at least six of them.
> > 
> > So let's comply with this requirement.
> 
> We can't directly, because that temp file needs to be a .c file.

The .c extension is mandatory?

> What can be done is create a temp file via mktemp and append .c later:
> _temp=$(mktemp -t dpdk.${0##*/}.XXXXXX)
> temp=${_temp}.c
> 
> Do we need this?

Yes I think it's better.

> >> Switched back to static assignment for `temp` in buildtools,
> >> but kept `dpdk.` prefix to preserve the common prefix intention.
> > 
> > It is a regression.
> > mktemp allows to choose the temporary directory thanks to TMPDIR
> > environment variable.