From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9688A343C for ; Mon, 1 Apr 2019 22:53:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 768DD21D8B; Mon, 1 Apr 2019 16:53:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 16:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wm+2uQajqDjNdWfR/oyTtr/bXtSi//MGJqfucyWP/ug=; b=O3tCOy3FVvpe rQFKZIihGH5j/UPXcQqew5ThAz2hScurIaLG1agPtNZzcQNW9r0GCBupm5HEl2k/ Qb90vIjOCnmIhqCtGDO2g7qcOehcF1w6jlIHoV7iYeLyQKNjDH2IQ1kQNBPHFBbM uMAHzzKg2wuPWzI67aep6MhiyQNMW08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Wm+2uQajqDjNdWfR/oyTtr/bXtSi//MGJqfucyWP/ ug=; b=uLFO/gMBABWNv2JmfL9O/JK0EXs3udnnbUHVipLiqOnNf+4feJoIZQiGQ 6URNw0vfHEB0S3m6SjosKwQTmPr/ehvh6VX2ry0jPm65f95DaOaY84G7mDqk0GpI +ksc6OFCxLf7qbAqz6mI8vI3kp5MtENLty6bLThRXCcrbVp9hrydpd46bI1GLH8L DOmxoL8+16EH8K6GUx5eXS+gCugLGZklxM/nJWTae4uogRa6wmWoeI8KVevlPTGd wzCYFNoe+bh+kXY2V6q3xScfLdrKHYDcGjL7srQ51ZX71a4xT4bJ7M7Yw2l82bMW cpT+xr0pbcBLipFuAyHv2nYjFVtaw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B0C4E1031A; Mon, 1 Apr 2019 16:53:37 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: dev@dpdk.org, Ferruh Yigit , Jerin Jacob Kollanukkaran , "arybchenko@solarflare.com" , "bernard.iremonger@intel.com" , Shahaf Shuler Date: Mon, 01 Apr 2019 22:53:36 +0200 Message-ID: <1732867.UvzobiCdsi@xps> In-Reply-To: <4ceb7729-22be-69e5-6636-a8a8d9397a4f@intel.com> References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190331131341.12924-1-pbhagavatula@marvell.com> <4ceb7729-22be-69e5-6636-a8a8d9397a4f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 20:53:42 -0000 01/04/2019 22:25, Ferruh Yigit: > On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > > From: Pavan Nikhilesh > > > > Optimize testpmd txonly mode by > > 1. Moving per packet ethernet header copy above the loop. > > 2. Use bulk ops for allocating segments instead of having a inner loop > > for every segment. > > > > Also, move the packet prepare logic into a separate function so that it > > can be reused later. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > v5 Changes > > - Remove unnecessary change to struct rte_port *txp (movement). (Bernard) > > > > v4 Changes: > > - Fix packet len calculation. > > > > v3 Changes: > > - Split the patches for easier review. (Thomas) > > - Remove unnecessary assignments to 0. (Bernard) > > > > v2 Changes: > > - Use bulk ops for fetching segments. (Andrew Rybchenko) > > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew Rybchenko) > > - Fix mbufs not being freed when there is no more mbufs available for > > segments. (Andrew Rybchenko) > > Hi Thomas, Shahafs, > > I guess there was a performance issue on Mellanox with this patch, I assume it > is still valid, since this version only has some cosmetic change, but can you > please confirm? We will check it. > And what is the next step, can you guys provide some info to Pavan to solve the > issue, or perhaps even better a fix? Looking at the first patch, there are still 3 changes merged together. Why not splitting even more? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C9473A0679 for ; Mon, 1 Apr 2019 22:53:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81DBB34F3; Mon, 1 Apr 2019 22:53:44 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9688A343C for ; Mon, 1 Apr 2019 22:53:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 768DD21D8B; Mon, 1 Apr 2019 16:53:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Apr 2019 16:53:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Wm+2uQajqDjNdWfR/oyTtr/bXtSi//MGJqfucyWP/ug=; b=O3tCOy3FVvpe rQFKZIihGH5j/UPXcQqew5ThAz2hScurIaLG1agPtNZzcQNW9r0GCBupm5HEl2k/ Qb90vIjOCnmIhqCtGDO2g7qcOehcF1w6jlIHoV7iYeLyQKNjDH2IQ1kQNBPHFBbM uMAHzzKg2wuPWzI67aep6MhiyQNMW08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Wm+2uQajqDjNdWfR/oyTtr/bXtSi//MGJqfucyWP/ ug=; b=uLFO/gMBABWNv2JmfL9O/JK0EXs3udnnbUHVipLiqOnNf+4feJoIZQiGQ 6URNw0vfHEB0S3m6SjosKwQTmPr/ehvh6VX2ry0jPm65f95DaOaY84G7mDqk0GpI +ksc6OFCxLf7qbAqz6mI8vI3kp5MtENLty6bLThRXCcrbVp9hrydpd46bI1GLH8L DOmxoL8+16EH8K6GUx5eXS+gCugLGZklxM/nJWTae4uogRa6wmWoeI8KVevlPTGd wzCYFNoe+bh+kXY2V6q3xScfLdrKHYDcGjL7srQ51ZX71a4xT4bJ7M7Yw2l82bMW cpT+xr0pbcBLipFuAyHv2nYjFVtaw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B0C4E1031A; Mon, 1 Apr 2019 16:53:37 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: dev@dpdk.org, Ferruh Yigit , Jerin Jacob Kollanukkaran , "arybchenko@solarflare.com" , "bernard.iremonger@intel.com" , Shahaf Shuler Date: Mon, 01 Apr 2019 22:53:36 +0200 Message-ID: <1732867.UvzobiCdsi@xps> In-Reply-To: <4ceb7729-22be-69e5-6636-a8a8d9397a4f@intel.com> References: <20190228194128.14236-1-pbhagavatula@marvell.com> <20190331131341.12924-1-pbhagavatula@marvell.com> <4ceb7729-22be-69e5-6636-a8a8d9397a4f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd txonly mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401205336.QHPqKM07WW12SgZRhIrKCcgjmSj0kVEWvqkPZCL2wE8@z> 01/04/2019 22:25, Ferruh Yigit: > On 3/31/2019 2:14 PM, Pavan Nikhilesh Bhagavatula wrote: > > From: Pavan Nikhilesh > > > > Optimize testpmd txonly mode by > > 1. Moving per packet ethernet header copy above the loop. > > 2. Use bulk ops for allocating segments instead of having a inner loop > > for every segment. > > > > Also, move the packet prepare logic into a separate function so that it > > can be reused later. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > v5 Changes > > - Remove unnecessary change to struct rte_port *txp (movement). (Bernard) > > > > v4 Changes: > > - Fix packet len calculation. > > > > v3 Changes: > > - Split the patches for easier review. (Thomas) > > - Remove unnecessary assignments to 0. (Bernard) > > > > v2 Changes: > > - Use bulk ops for fetching segments. (Andrew Rybchenko) > > - Fallback to rte_mbuf_raw_alloc if bulk get fails. (Andrew Rybchenko) > > - Fix mbufs not being freed when there is no more mbufs available for > > segments. (Andrew Rybchenko) > > Hi Thomas, Shahafs, > > I guess there was a performance issue on Mellanox with this patch, I assume it > is still valid, since this version only has some cosmetic change, but can you > please confirm? We will check it. > And what is the next step, can you guys provide some info to Pavan to solve the > issue, or perhaps even better a fix? Looking at the first patch, there are still 3 changes merged together. Why not splitting even more?