From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 77A5C2C00 for ; Fri, 18 Mar 2016 12:01:57 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so31621085wml.1 for ; Fri, 18 Mar 2016 04:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=h+ngMRKBuKN1QKrbXMtQs3nplcp51L+TZg4ANbnQHqQ=; b=R5ypWKbKZ+sKck5JB9+tZdiN73t+iKk4KmVhaq4PKKiZJGxAWdaBGTY7CbvqQOWE/7 hph+eI6EC+fghmbohCkGtT+fJq/Jq7IlsH8D3F3fKLo9/8U8KAPJKpVJLdDzOC6Rb2dN pbtxbEjWzsafSkt0Lp8C1b/cLuRPPsWRtaC4N25lH86GF+E3gZk61zILQKIGLtE5NNPO HmDXUtSRAJqu2hvMsJGZChJu8wgFHVLp9Lma4Z6zpInjqGlelf0bqfRSr72ZSncdVlgh yc+s72M6ZPqcZJSraUt+xea5It67u+GUy2vdr8TuxxMINNwk3JXJi5K/4yrJvD/8uJ1F Bk8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=h+ngMRKBuKN1QKrbXMtQs3nplcp51L+TZg4ANbnQHqQ=; b=TAQsw56ZgrN6MGHZwqPoPLtT5ZyoSmpOT3945izpjjBVivFm6IxTCyYneH/QjihXy5 mDRDJqozYom0uEXKjutXTKSvkr/UmKcM7QD6v2kLT+HHbdaBY3o7c9Z/PNHs400ShzQ2 ynyEvyQz4D+NSi/XIY14AbYunnRV3J0Rwi0kRifAuQB86iOJwGH6YQErmheB1mrfNt0y XV842+HN+SUChLVaFPYGh9/ILXwSqfDe2Q7MwpV/HKatQYgmIj9YnJQutSkZzvpYvV5I BgoX8BWLcojku7/FJX9lTqMYJGRwAX/HIhuc7vfZoMy2biceE8pL9VzhbRbE1XOTu6uZ pQjg== X-Gm-Message-State: AD7BkJK+04+LW1EHm7upVQpnV07DHu1KYLUDCmzlBkyv+jm3edsddWidtT1RIp14VSjEXsCl X-Received: by 10.194.75.164 with SMTP id d4mr15273344wjw.15.1458298917318; Fri, 18 Mar 2016 04:01:57 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id i1sm11675520wjs.45.2016.03.18.04.01.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2016 04:01:56 -0700 (PDT) From: Thomas Monjalon To: Jerin Jacob , Tomasz Kulasek , Jan Viktorin Cc: dev@dpdk.org, jianbo.liu@linaro.org Date: Fri, 18 Mar 2016 12:00:24 +0100 Message-ID: <1734050.PspUeD4iGQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160318105158.GA13693@localhost.localdomain> References: <1458293807-2604-1-git-send-email-tomaszx.kulasek@intel.com> <1902439.xcempkFplY@xps13> <20160318105158.GA13693@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] examples/l3fwd: em path performance fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 11:01:57 -0000 2016-03-18 16:22, Jerin Jacob: > On Fri, Mar 18, 2016 at 11:04:49AM +0100, Thomas Monjalon wrote: > > 2016-03-18 10:52, Tomasz Kulasek: > > > +#if !defined(NO_HASH_MULTI_LOOKUP) && defined(__ARM_NEON) > > > > I think we should use CONFIG_RTE_ARCH_ARM_NEON here. > > Any ARM maintainer to confirm? > > __ARM_NEON should work existing GCC, but it is better to use > RTE_MACHINE_CPUFLAG_NEON as > -it has been generated by probing the compiler capabilities. > -it's future-proof solution to support clang or other gcc versions in > future I agree to use RTE_MACHINE_CPUFLAG_NEON. I just don't understand why CONFIG_RTE_ARCH_ARM_NEON has been introduced. It seems to be used to disable NEON on ARMv7: ifeq ($(CONFIG_RTE_ARCH_ARM_NEON),y) MACHINE_CFLAGS += -mfpu=neon endif