From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4917B1B824 for ; Tue, 17 Oct 2017 18:13:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C184F20CF1; Tue, 17 Oct 2017 12:13:15 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 17 Oct 2017 12:13:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ZdIj7b80HQTFWpQK4BETg9kgFh 1EDl3aaLHcuxiHb7o=; b=q3wAzxnVrAVMl41h42xBdVRJCL1a3g5MLJnYw/XQME SA3u1shz9fjlHRg84v59j2eFFaHmBA/PXn4e8wt1p8QXMPTV3SRqjwtzPcKtMT7k 39sQflEUMc/Oj/+upiq9/PMsVYrXUFJlJYRZ2tkdE06lH04d0pRvrxFwTyInn7tg o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ZdIj7b 80HQTFWpQK4BETg9kgFh1EDl3aaLHcuxiHb7o=; b=gNIi36D8L14Ojb1eQ9c52E p1RIK6MchOIanlVRodbdQzYVVGN5dKzF8gXRZ5Ew/0yNluJDpguM/EAQqtD9ttUx zNWAYiE27gdqlRacbKOeKiqsjrGpQjyZN1PvmKQnKYQpGraOyYpqdkv05niPMZJk fGjmx9RGKOSqdPb/Ik4vSwxbFtJIja4Msi4JBW66Yx8pPLwBXFeflQYwHovCeX2Y eAZE3X1NYgl6F8J8V23/ZpthcJ0OngZEUMRAiFDt2d4hh4Cj5QGFshUgoOg/yAr+ oy2JV87gKQeRE29umCBkQCCmAsMK+6mGi3lywmfw3pz6CnRtvMffbq0uVxI1gPMw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 549D3241D9; Tue, 17 Oct 2017 12:13:15 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" , Alexey Kardashevskiy Cc: dev@dpdk.org Date: Tue, 17 Oct 2017 18:13:14 +0200 Message-ID: <1734105.V98Xar4r66@xps> In-Reply-To: References: <20170426080908.24026-1-aik@ozlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 16:13:16 -0000 28/04/2017 13:19, Burakov, Anatoly: > From: Alexey Kardashevskiy > > VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for > > just created DMA window. It happens to start from zero because the default > > window is removed (leaving no windows) and new window starts from zero. > > However this is not guaranteed and a new window may start from another > > address, this adds a check and an error message. > > > > > > Signed-off-by: Alexey Kardashevskiy > > --- > > Changes: > > v2: > > * this just prints warning and fails instead of incorrectly changing IOVA > > addresses > > --- > > Hi Alexey, > > There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :) > > I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though. Please, can we progress on this patch? Is it still a relevant patch? If yes, someone to make a v3, please?