From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 2B5371DB1 for ; Mon, 7 Nov 2016 18:23:01 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id p190so196937623wmp.1 for ; Mon, 07 Nov 2016 09:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=FaLqUM6HTTI6bfe28ZSwHFM06cgV2nIPN65p2FaZ6gE=; b=pKYLSzZagLSDUFSlDj0lk44wkuXK9ec6a3/CF0xcqAkq6ckXyEWkqj4OeYKtWX1wtk wiqIs1/QNwpYxsaiPbdrcnKomBNu1TitEttdkmrp/yyLz3cXSKO9eMmqWn4jesZdi5tU H/SC8TmqVkLJRKZyzBoQTzweuap1xo77y/ZrLvp8j5y0T7hD+rzAerc00MUBCl0wnkka UGknPZr/MnyRQbi4AvzqWqgNaquJpkMS/qxb02SSp16anRm9cIXqH48h3xRGyzOS9i5O FN88yVxjTlNpg+5Swafu3M4eNisD4HIT+tW5j2uGp6gKHpkW09m5w+GmSZyScj7kW6dq 0Fsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=FaLqUM6HTTI6bfe28ZSwHFM06cgV2nIPN65p2FaZ6gE=; b=iQDb+ATd5hunXVXXBelYJH0Tuzuqw10FgXrc0fGMm5UwwSDFUjOJc5MwOFZvbIJbN8 z4C74WxFfxtRBdmJxpGrAsqvii14ZHnepDPpF0y57vtCnwDAu0Wu0Fc6nYtdJVVMvqe7 Gw/O2lrcEz5fURbbkGdEXrWPG7AHwEW+YxIGP5KjeGxLeFEQI3RXa0N5u/NEjnF4JtDE hz54tmvx/3ePl7D1h58ad+WwOlpl1BCSXyFfompaeItf0Uzk5lqNxIDeQZIEPQWXFQhS 1wX4Y1XWNkYM+043xn5hijFtuN572A77f9olJNKNRxZPUTlNwe95XEqhqjFHkuGn4/ul hN+w== X-Gm-Message-State: ABUngvcMFcHL847ljRabDo04JMHzRKP0rQ5/VJY9V510mDHPMJ1I9DmYyy/fEiMxEbFGkdmC X-Received: by 10.28.131.72 with SMTP id f69mr7586453wmd.33.1478539380892; Mon, 07 Nov 2016 09:23:00 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id n72sm14688396wmd.11.2016.11.07.09.22.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 09:23:00 -0800 (PST) From: Thomas Monjalon To: Raslan Darawsheh Cc: dev@dpdk.org, Adrien Mazarguil Date: Mon, 07 Nov 2016 18:22:59 +0100 Message-ID: <1734224.1G63DZ4fph@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161028121906.GW5733@6wind.com> References: <937aac679e571c4fff8ab720f4dd910fe10a283e.1477296585.git.rasland@mellanox.com> <20161028121906.GW5733@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix handling of small mbuf sizes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 17:23:01 -0000 2016-10-28 14:19, Adrien Mazarguil: > On Mon, Oct 24, 2016 at 11:10:59AM +0300, Raslan Darawsheh wrote: > > When mbufs are smaller than MRU, multi-segment support must be enabled to > > default set when not in promiscuous or allmulticast modes. > > > > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support") > > > > Signed-off-by: Raslan Darawsheh [...] > > + /* If smaller than MRU, multi-segment support must be enabled. */ > > + if (mb_len < (priv->mtu > dev->data->dev_conf.rxmode.max_rx_pkt_len ? > > + dev->data->dev_conf.rxmode.max_rx_pkt_len : > > + priv->mtu > > + )) > > Let's move poor "))" to the end of the previous line. [...] > Besides the above comment: > > Acked-by: Adrien Mazarguil Fixed and applied, thanks