From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 5099958C5 for ; Thu, 1 Dec 2016 17:24:14 +0100 (CET) Received: by mail-wj0-f180.google.com with SMTP id qp4so209322362wjc.3 for ; Thu, 01 Dec 2016 08:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=d54jO99H75JfBgCz0SUCh/Gn2WbSV6EiI2OSfJT2plA=; b=jkhMVX19bRlq/FifrNXO4akaj69ioafPU2bOpawXtAbJajWUAv4ZG8t9k17T6Ku4hG 6NIX3rMrTgcYLBYWhuwUaySOKrqbasznv+L4Pj8VzAPAbRuQ0guG27ywvYa729RL2/j1 kKdSkOc6jfGMIfdHBk4wHrGovAm4cWY7j00LIAsGAWdjdwumhFpnYkn9VvF5U+KPZZy8 GnasDHfA3J1LzPcJMvPFsz+unr5fKzh3C6mtxnk2+96yyI9mjBp++KqmYp6qd2AkUN+t 2ghnH+ONNwkjkvRuLd3S4Z0NvVYOg22vPYrM6uuZS1SZaEh4QapZsm0vVRmGuTaSIvQ1 5jmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=d54jO99H75JfBgCz0SUCh/Gn2WbSV6EiI2OSfJT2plA=; b=HViGqO5Ip2INgKlXH6L9pcLVZzk8r9OTfOnUORhCLlRBatKxPP8i5ovRKGE0AhUhwx XfexDo8yqQDjM3JFRdTICLfmL5yTFh2sULngGx55HII7Bm5SZnB2ljc43hTH9gogFZuo ktmpRzfc+nc8FYXNQSZSlwWI5VrVVNBUBwjGL7y2fCcMo1nKea7kY6w9GI26trsR902Q 7tMTAchryLs+D1uZSD0ilziun3MBg9SNAoG695fpbIBpUnyHa64+dvmHTbn/ko9RcWhE trOdGdmahPGGWPHsvgdoa7zVJ/HV2JbHDOf0pbdHerpvMRvwTkbNvA+InXjinzC94oUK UX1w== X-Gm-Message-State: AKaTC00MGGe7O7hGHkqGaMe2P3BeU10ridL63I5SAWZvbcpzc2Md9wIl8sv1aUaf+HUlFqp2 X-Received: by 10.194.171.104 with SMTP id at8mr34342864wjc.159.1480609454040; Thu, 01 Dec 2016 08:24:14 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d64sm13979677wmh.3.2016.12.01.08.24.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2016 08:24:12 -0800 (PST) From: Thomas Monjalon To: Tomasz Kulasek Cc: dev@dpdk.org, konstantin.ananyev@intel.com, olivier.matz@6wind.com, bruce.richardson@intel.com Date: Thu, 01 Dec 2016 17:24:11 +0100 Message-ID: <1734448.0id6dCbsBT@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <15420823.7ghYzVRe3h@xps13> References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-2-git-send-email-tomaszx.kulasek@intel.com> <15420823.7ghYzVRe3h@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v12 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 16:24:14 -0000 Please, a reply to this question would be greatly appreciated. 2016-11-28 11:54, Thomas Monjalon: > Hi, > > 2016-11-23 18:36, Tomasz Kulasek: > > --- a/config/common_base > > +++ b/config/common_base > > @@ -120,6 +120,7 @@ CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 > > CONFIG_RTE_LIBRTE_IEEE1588=n > > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > > CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y > > +CONFIG_RTE_ETHDEV_TX_PREPARE=y > > Please, remind me why is there a configuration here. > It should be the responsibility of the application to call tx_prepare > or not. If the application choose to use this new API but it is > disabled, then the packets won't be prepared and there is no error code: > > > +#else > > + > > +static inline uint16_t > > +rte_eth_tx_prepare(__rte_unused uint8_t port_id, __rte_unused uint16_t queue_id, > > + __rte_unused struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > +{ > > + return nb_pkts; > > +} > > + > > +#endif > > So the application is not aware of the issue and it will not use > any fallback.