From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 8C4245589 for ; Mon, 12 Sep 2016 11:55:07 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id c131so48305710wmh.0 for ; Mon, 12 Sep 2016 02:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=607fHxo0yy6jvm5oZnsQ2sK6rgeKnqvLHSmuYbT2XBc=; b=nkNxyHRinz02WakP80fddRtgkp1ZPvzUDAEgRRclVx9tjVgX3Q68gt+7Q9dOhKL8Hx CpxNTF0qPqfTsWzAxyYjxfFLA8tdZEwDThYzOR3VMPP84wocJyPDY40AYPwZpH20UhAM laBCn6zglK8bFBXQRJKVUXot7/Gr+2wBnIi56a5jb5fupFP1+86EyaclwJVCjzkLJvp+ mVAj1rsR7MBWayj6RJWlovO5kOC134d2L4Vq7URwx3Ny2y+aihad6nGn4yDLd/C3Asdn O5ieF1TVtMXWUrAGXEYPvwtlYyoqnHC2OmswIwO9jd2c+1UJ3UQfrf7RXsZCh+/LJl7T Og+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=607fHxo0yy6jvm5oZnsQ2sK6rgeKnqvLHSmuYbT2XBc=; b=B11jZlSHfQU5iD9FojPN5wQ4mdmxbA2qD8aUiX151ic1FE2Oa/DKvmn4HFcu/WTXvH QWCyf0fFNIPiBHCP6UvQGJMnEOlNLFqqP+lmtlK7NcJKfypw1mZOysMq22QlNH+A8Hqe YF7Fr8xWIaP4wqxF2o+zpMl3KkT+gu0lXmSs4ihSaUBlCVQOykiF6MZ9iIr5DKCl//vA fbJkuDlP9HhghOaeeXaO+fI0KqutskpE2e8oDUmiWOHwUVZTF6wmuKse5rVV2DJpSEra pTyNG1Caqx85kvPPjbfE5zTcD5N+/iWQlAjYdsYqjtewlkFEgzUIPAISuRgbDKcmubMP BihQ== X-Gm-Message-State: AE9vXwP6tSV6gz/DWLlGKHc8c28XRuRCYn1gmimPoxcvZtiIjXo893aB464H3zewcCZ4Xh5h X-Received: by 10.28.214.130 with SMTP id n124mr9267233wmg.37.1473674107231; Mon, 12 Sep 2016 02:55:07 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id j1sm17090430wju.9.2016.09.12.02.55.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Sep 2016 02:55:06 -0700 (PDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Shreyansh Jain , hemant.agrawal@nxp.com Date: Mon, 12 Sep 2016 11:55:05 +0200 Message-ID: <1734475.YWCHRY6Pyt@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-8-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 07/25] driver: init/uninit common wrappers for PCI drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 09:55:07 -0000 2016-09-12 09:16, David Marchand: > On Wed, Sep 7, 2016 at 4:07 PM, Shreyansh Jain wrote: > > crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for > > init/uninit can be easily reused for this. > > I would keep in the commit log a mention on the 1 - 1 association > between the ethdev/crypto device and the pci device. > > Besides, I kind of remember a suggestion to rename init as probe and > uninit as remove (Thomas ?). Yes, here: http://dpdk.org/ml/archives/dev/2016-July/044086.html > But this can go later in the series.