From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: stephen@networkplumber.org, bruce.richardson@intel.com,
dev@dpdk.org, vladimir.medvedkin@intel.com
Subject: [PATCH v3] app/test: fix stack overflow in lpm6_perf_autotest
Date: Wed, 18 Dec 2024 07:21:26 -0800 [thread overview]
Message-ID: <1734535286-27267-1-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1734057571-20367-1-git-send-email-andremue@linux.microsoft.com>
Test lpm6_perf_autotest was hitting a stack overflow on Windows
with both MSVC and Clang.
The fix is to move some of the data from the stack to the heap.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
app/test/test_lpm6_perf.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/app/test/test_lpm6_perf.c b/app/test/test_lpm6_perf.c
index 1860a99ed6..59df0a958a 100644
--- a/app/test/test_lpm6_perf.c
+++ b/app/test/test_lpm6_perf.c
@@ -10,6 +10,7 @@
#include <rte_cycles.h>
#include <rte_random.h>
+#include <rte_malloc.h>
#include <rte_memory.h>
#include <rte_lpm6.h>
@@ -117,8 +118,13 @@ test_lpm6_perf(void)
total_time = 0;
count = 0;
- struct rte_ipv6_addr ip_batch[NUM_IPS_ENTRIES];
- int32_t next_hops[NUM_IPS_ENTRIES];
+ struct rte_ipv6_addr *ip_batch = rte_calloc("ip_batch",
+ NUM_IPS_ENTRIES, sizeof(struct rte_ipv6_addr), 0);
+ TEST_LPM_ASSERT(ip_batch != NULL);
+
+ int32_t *next_hops = rte_calloc("next_hops",
+ NUM_IPS_ENTRIES, sizeof(int32_t), 0);
+ TEST_LPM_ASSERT(next_hops != NULL);
for (i = 0; i < NUM_IPS_ENTRIES; i++)
ip_batch[i] = large_ips_table[i].ip;
@@ -153,6 +159,9 @@ test_lpm6_perf(void)
printf("Average LPM Delete: %g cycles\n",
(double)total_time / NUM_ROUTE_ENTRIES);
+ rte_free(next_hops);
+ rte_free(ip_batch);
+
rte_lpm6_delete_all(lpm);
rte_lpm6_free(lpm);
--
2.47.0.vfs.0.3
prev parent reply other threads:[~2024-12-18 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 2:39 [PATCH] " Andre Muezerie
2024-12-13 10:22 ` Medvedkin, Vladimir
2024-12-13 17:05 ` Andre Muezerie
2024-12-13 17:08 ` Stephen Hemminger
2024-12-13 17:08 ` [PATCH v2] " Andre Muezerie
2024-12-13 17:15 ` Stephen Hemminger
2024-12-18 15:12 ` Andre Muezerie
2024-12-18 15:21 ` Andre Muezerie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1734535286-27267-1-git-send-email-andremue@linux.microsoft.com \
--to=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).