From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id A98628E65 for ; Thu, 31 Mar 2016 15:59:00 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id p65so115938838wmp.0 for ; Thu, 31 Mar 2016 06:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=SB2XgE+6uYfWMpGk63D9JR08nssU4MuLVHo7sk26XDk=; b=aYiRx+s1IjfC8+0BpboqQOgtF0zc6YeDMMIruPmofmLRqn2dSeWuMARgZpEXGhG3aQ Su5HBB2f0ekbO1jl/NxhJo376r9LE6nfnoQ/1dAPqA7tLW2Z+6qvMotJWM6AMH4sraa+ g7T1PaivjCxf7NYudkiIVjCeXFWcEqC9tZk1tVTWX1NyWz9rwKYdwv07ir6S7mdqo5vY duUtPvAA8RwDknkWr9V4LVUn1rMaq9dnWeqes+ZyGIPxgdWXscaGywb5pnIDi1eSrmgj 1EXyR3DkA8u1qfA1wYBun+Jk4mU8KuS9NbW2b4w+h7xszZjye87BSMTz9puO9i5p29ak ILhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=SB2XgE+6uYfWMpGk63D9JR08nssU4MuLVHo7sk26XDk=; b=Di/Z1y+KCYCDdGNudow4u3c4WOQlLGIp51sMSV3Ql9tWRe3Ohg7gAhArVBODF1r5Qb /uZBLCmPxf/I/dOxax3xQPcTVd7KsTHEmEVZtB0wqejSlWgD+Zoosdatzf5aNc5ps7sK 9BjyFColyRtox6A/Lg8czB/S1/ZjpmqjyjurshxfztCbohiDfjnJd7+aNxKvQxjxjalb 2IxdoOPuytErEHdn9bIxJO75e6Vehfvyg+Vi52dDcyad6CimoxP5/pre/mINO3W2wRJp ZsO5TYaGtMhk7tEC+s/VU1kOvIoZ+rk26wZm1szkoVJwuRJ/09xLtuL8kK7cMhtJ2kNx lMIQ== X-Gm-Message-State: AD7BkJJlrtQJfFq9vQqqBh5JLFGKC4QfB03p8XT7r8L91TenPvfkr2NjnPg2wPqqMEgzZPch X-Received: by 10.194.8.38 with SMTP id o6mr3466837wja.31.1459432740492; Thu, 31 Mar 2016 06:59:00 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id s66sm25114371wmb.6.2016.03.31.06.58.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 06:58:59 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Michael Frasca , "Chen, Jing D" Date: Thu, 31 Mar 2016 15:57:07 +0200 Message-ID: <1734643.Kgakri6QQ3@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <06A5CC0C-D767-48CD-B82D-C4C81AD282AE@oracle.com> References: <1458665888-4577-1-git-send-email-michael.frasca@oracle.com> <4341B239C0EFF9468EE453F9E9F4604D04465361@shsmsx102.ccr.corp.intel.com> <06A5CC0C-D767-48CD-B82D-C4C81AD282AE@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 13:59:00 -0000 Please, anyone to confirm that the patch is valid and must be applied? This discussion shows some doubts. 2016-03-24 13:35, Michael Frasca: > Jing, > > Thanks for your assistance. The experiment that you have built should allow you > to observe the bug. In [5], I would expect that queue 0 receives roughly 1/4 of > the packets that you sending, assuming the input packets have varied IP > addresses. Can you measure what % of packets are actually being received in this > single queue setup (after first running a 4-queue setup)? > > When trying to running with only one RX queue, the fm10k retains the same RSS > hash function and redirection table that was configured from a previous run. As > a result, some packets are still being directed to other receive queues. I have > confirmed this by polling the queue specific stats, which I retrieved via > rte_eth_xstats_get(). > > Looking at fm10k_dev_rss_configure(), one should see that there is no > modification of fm10k registers when nb_rx_queues == 1. As far as I can tell, > this is the reason that only a certain partition of packets are being receive in > a single queue setup (after first running a multi-queue configuration). > > I am unable to access my development environment today, but if you need, I can > later craft a patch to l3fwd that shows the measurement of packets received at > each queue. > > Thanks, > Mike > > > > On Mar 24, 2016, at 2:40 AM, Chen, Jing D wrote: > > > > Hi, Frasca, > > > > > > > >> -----Original Message----- > >> From: Michael Frasca [mailto:michael.frasca@oracle.com ] > >> Sent: Wednesday, March 23, 2016 9:43 PM > >> To: Chen, Jing D > >> Cc: dev@dpdk.org > >> Subject: Re: [PATCH] fm10k: conditionally disable RSS during device > >> initialization > >> > >> Hi Jing, > >> > >> I ran into this issue while trying to run experiments with different RSS > >> configurations (no RSS being one cases). It is not clear to me that setting this > >> register to zero is the best way to disable RSS. > >> > >> After digging further, I have a theory that I'm having this issues because I've > >> only attached my DPDK application to SR-IOV ports. In > >> fm10k_dev_dglort_map_configure(), I see that 'RSS Length' is set for the > >> DGLORT > >> decoder. However, it appears that this is only invoked for physical functions. > >> > >> Could this be my problem? Is it required that I bind to the physical function > >> if I want to properly manipulate RSS? > >> > >> Thanks, > >> Mike > >> > > I don't know exactly what problem you ran into. I think we needn't worry about > > those DGLORT setting when using VF device. > > > > I've followed steps to use SRIOV device with RSS enabled and disabled, both > > are worked well from my side after applying your patch. Below is my setup. > > > > 1. PF with Linux driver "fm10k-next_0.19.3". > > 2. DPDK with latest code from master branch, apply your patch. > > 3. Use 1 VF device created by kernel driver. > > 4. use l3fwd with " ./examples/l3fwd/build/l3fwd -c fc -n 4 -- -p 0x1 --config="(0,0,2),(0,1,2),(0,2,3),(0,3,3)"" > > with RSS enabled. After sending packets, I can see all 4 queues received packets. > > 5. use l3fwd with " ./examples/l3fwd/build/l3fwd -c fc -n 4 -- -p 0x1 --config="(0,0,2)"" > > with RSS disabled. After sending packets, I can see queue 0 received packets. > > > > Can you explain what actual problem is? > > We can talk offline. >