From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BFBF45F25; Mon, 23 Dec 2024 20:13:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A918E4066A; Mon, 23 Dec 2024 20:12:33 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 44832402D6 for ; Mon, 23 Dec 2024 20:12:16 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id CBD42206ADDB; Mon, 23 Dec 2024 11:12:14 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CBD42206ADDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1734981134; bh=qNursffL/PcZjTNSkE/OEu4K4ssUIMCJczQ7ppcbuw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PQlglzZ6YfIaTXvrUMW2wcpnOBrs/wNViTuiyIPVwrhryIbF1Q99u54HOw9OtqmuB D+xEWiGpQ6VQg/KiLSxpWngsfG6sbm/6vyw3ih6LF9rBDhmpW/pjfhFLj7mXewE9lT 4PLaYNF51s0F4yEVyLlwFewzt9vEZsMzD1mbHo90= From: Andre Muezerie To: roretzla@linux.microsoft.com Cc: aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com, Andre Muezerie Subject: [PATCH v7 13/29] drivers/mempool: replace packed attributes Date: Mon, 23 Dec 2024 11:11:46 -0800 Message-Id: <1734981122-4729-14-git-send-email-andremue@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1734981122-4729-1-git-send-email-andremue@linux.microsoft.com> References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1734981122-4729-1-git-send-email-andremue@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org MSVC struct packing is not compatible with GCC. Replace macro __rte_packed with __rte_packed_begin to push existing pack value and set packing to 1-byte and macro __rte_packed_end to restore the pack value prior to the push. Macro __rte_packed_end is deliberately utilized to trigger a MSVC compiler warning if no existing packing has been pushed allowing easy identification of locations where the __rte_packed_begin is missing. Signed-off-by: Andre Muezerie Reviewed-by: Tyler Retzlaff --- drivers/mempool/octeontx/octeontx_fpavf.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c index 966fee8bfe..d2eb837c17 100644 --- a/drivers/mempool/octeontx/octeontx_fpavf.c +++ b/drivers/mempool/octeontx/octeontx_fpavf.c @@ -46,20 +46,20 @@ struct octeontx_mbox_fpa_cfg { uint64_t aura_cfg; }; -struct __rte_packed gen_req { +__rte_packed_begin struct gen_req { uint32_t value; -}; +} __rte_packed_end; -struct __rte_packed idn_req { +__rte_packed_begin struct idn_req { uint8_t domain_id; -}; +} __rte_packed_end; -struct __rte_packed gen_resp { +__rte_packed_begin struct gen_resp { uint16_t domain_id; uint16_t vfid; -}; +} __rte_packed_end; -struct __rte_packed dcfg_resp { +__rte_packed_begin struct dcfg_resp { uint8_t sso_count; uint8_t ssow_count; uint8_t fpa_count; @@ -67,7 +67,7 @@ struct __rte_packed dcfg_resp { uint8_t tim_count; uint8_t net_port_count; uint8_t virt_port_count; -}; +} __rte_packed_end; #define FPA_MAX_POOL 32 #define FPA_PF_PAGE_SZ 4096 -- 2.47.0.vfs.0.3